src: remove unused http2_socket_buffer from env - #14740
Closed
addaleax wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
cjihrig
approved these changes
Aug 10, 2017
bnoordhuis
approved these changes
Aug 10, 2017
tniessen
approved these changes
Aug 10, 2017
addaleax
added a commit
to addaleax/node
that referenced
this pull request
Aug 10, 2017
PR-URL: nodejs#14740 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Copy link
Copy Markdown
Member
|
Whoops! I thought I had removed that one already! Thank you @addaleax! :-D |
Sorry, something went wrong.
jasnell
pushed a commit
to jasnell/node
that referenced
this pull request
Aug 13, 2017
PR-URL: nodejs#14740 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
addaleax
added a commit
that referenced
this pull request
Aug 14, 2017
PR-URL: #14740 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I’d go so far as to say that this doesn’t need to wait 48 hours.
Checklist
Affected core subsystem(s)
http2