http2: use per-environment buffers - #14744
Merged
addaleax merged 2 commits intoAug 13, 2017
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
jasnell
approved these changes
Aug 10, 2017
jasnell
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Woo! thank you! (it's always a happy day when someone takes something off your todo list ;-) ...). This LGTM.
Another possible approach is to make these buffers per-Http2Session but given how they're used, per-Environment works well too. Love the additional code cleanups included
Sorry, something went wrong.
As discussed in the review for nodejs#14239, these buffers should be per-Environment rather than static. PR-URL: nodejs#14744 Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#14744 Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
force-pushed
the
http2-buffers
branch
from
d74ba7e to
5ea25d2
Compare
August 13, 2017 15:21
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
jasnell
pushed a commit
to jasnell/node
that referenced
this pull request
Aug 13, 2017
As discussed in the review for nodejs#14239, these buffers should be per-Environment rather than static. PR-URL: nodejs#14744 Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
pushed a commit
to jasnell/node
that referenced
this pull request
Aug 13, 2017
PR-URL: nodejs#14744 Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
added a commit
that referenced
this pull request
Aug 14, 2017
PR-URL: #14744 Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in the review for #14239, these buffers should be per-Environment rather than static.
Checklist
Affected core subsystem(s)
http2