[v8.x backport] encoding: rudimentary TextDecoder support w/o ICU - #14786
Closed
TimothyGu wants to merge 1 commit into
Closed
[v8.x backport] encoding: rudimentary TextDecoder support w/o ICU#14786TimothyGu wants to merge 1 commit into
TimothyGu wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Also split up the tests. PR-URL: nodejs#14489 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
addaleax
approved these changes
Aug 12, 2017
Copy link
Copy Markdown
Member
|
Landed in c5ee34e, thanks for backporting! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also split up the tests.
PR-URL: #14489
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Refael Ackermann refack@gmail.com
Checklist
Affected core subsystem(s)
encoding