doc: update README with SHASUMS256.txt.sig info - #15107
Closed
maclover7 wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
lpinca
approved these changes
Sep 1, 2017
lpinca
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
SGTM.
Sorry, something went wrong.
jasnell
approved these changes
Sep 1, 2017
BridgeAR
approved these changes
Sep 2, 2017
Copy link
Copy Markdown
Member
|
beautiful work! this is exactly what's needed, thanks for contributing this. My only one ask is that you make sure you keep the line lengths of non-breakable text to 80 characters maximum as that's the standard for this file. |
Sorry, something went wrong.
rvagg
suggested changes
Sep 12, 2017
Comment thread
README.md
Outdated
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
81 chars I think, need to break this to <=80
Sorry, something went wrong.
Comment thread
README.md
Outdated
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
81 chars again
Sorry, something went wrong.
It is more secure to verify SHASUMS256.txt files via SHASUMS256.txt.sig than SHASUMS256.txt.asc. [This comment](#6821 (comment)) does the best job at explaining the issue. Refs: #6821, #9071
rvagg
approved these changes
Sep 13, 2017
rvagg
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
sweet 👌
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Landed @ c1fce1e, marking for backport to LTS |
Sorry, something went wrong.
rvagg
pushed a commit
that referenced
this pull request
Sep 13, 2017
It is more secure to verify SHASUMS256.txt files via SHASUMS256.txt.sig than SHASUMS256.txt.asc. This comment does the best job at explaining the issue: #6821 (comment) Refer: #6821 Refer: #9071 PR-URL: #15107 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Sep 20, 2017
It is more secure to verify SHASUMS256.txt files via SHASUMS256.txt.sig than SHASUMS256.txt.asc. This comment does the best job at explaining the issue: #6821 (comment) Refer: #6821 Refer: #9071 PR-URL: #15107 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 17, 2017
It is more secure to verify SHASUMS256.txt files via SHASUMS256.txt.sig than SHASUMS256.txt.asc. This comment does the best job at explaining the issue: #6821 (comment) Refer: #6821 Refer: #9071 PR-URL: #15107 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Oct 25, 2017
It is more secure to verify SHASUMS256.txt files via SHASUMS256.txt.sig than SHASUMS256.txt.asc. This comment does the best job at explaining the issue: #6821 (comment) Refer: #6821 Refer: #9071 PR-URL: #15107 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This was referenced Apr 28, 2023
This was referenced Apr 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is more secure to verify SHASUMS256.txt files via SHASUMS256.txt.sig
than SHASUMS256.txt.asc.
This comment does the best job at explaining the issue.
Refs: #6821, #9071
Checklist
Affected core subsystem(s)
doc