FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Backport fs.copyFile{Sync} to v8.x by cjihrig · Pull Request #15322 · nodejs/node · GitHub

/ node Public

Backport fs.copyFile{Sync} to v8.x - #15322

Closed
cjihrig wants to merge 1 commit into
nodejs:v8.x-stagingfrom
cjihrig:v8.x-staging
Closed

Backport fs.copyFile{Sync} to v8.x#15322
cjihrig wants to merge 1 commit into
nodejs:v8.x-stagingfrom
cjihrig:v8.x-staging

Conversation

cjihrig commented Sep 10, 2017

Copy link
Copy Markdown
Contributor

fs: add fs.copyFile{Sync}

Fixes: #14906
PR-URL: #15034
Reviewed-By: Timothy Gu timothygu99@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
Reviewed-By: Tobias Nießen tniessen@tnie.de

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

Fixes: nodejs#14906
PR-URL: nodejs#15034
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. v8.x labels Sep 10, 2017
cjihrig mentioned this pull request Sep 10, 2017
4 tasks

Copy link
Copy Markdown
Contributor

landed in ce56cff

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL