[v6.x backport] doc: add documentation on ICU - #15353
Conversation
Sorry, something went wrong.
There was a problem hiding this comment.
Default v6.11.3 prints M01 for me (Windows 7 x64).
Sorry, something went wrong.
There was a problem hiding this comment.
Hmm, it's M01 for me on master as well but January on v6.x. Can you check the output after changing your LC_ALL environment variable to en_US?
Sorry, something went wrong.
There was a problem hiding this comment.
> set LC_ALL=en_US
> set LC_ALL
LC_ALL=en_US
> node.6.11.3.v8-5.1.exe
> const january = new Date(9e8);
> const english = new Intl.DateTimeFormat('en', { month: 'long' });
> const spanish = new Intl.DateTimeFormat('es', { month: 'long' });
> console.log(english.format(january));
January
> // Prints "January"
> console.log(spanish.format(january));
M01
> // Prints "January" on small-icu
> // Should print "enero"
Sorry, something went wrong.
There was a problem hiding this comment.
FWIW, I use the standalone binary from https://nodejs.org/download/release/latest-v6.x/win-x64/
Sorry, something went wrong.
There was a problem hiding this comment.
Ah you are on Windows. That's different...
Sorry, something went wrong.
There was a problem hiding this comment.
So maybe we can state "January" or "M01"?
Sorry, something went wrong.
There was a problem hiding this comment.
@vsemozhetbyt Sounds like a good idea.
Sorry, something went wrong.
vsemozhetbyt
left a comment
There was a problem hiding this comment.
With code output recheck.
Sorry, something went wrong.
PR-URL: nodejs#13916 Refs: nodejs#13644 (comment) Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
PR-URL: #13916
Refs: #13644 (comment)
Reviewed-By: Vse Mozhet Byt vsemozhetbyt@gmail.com
Checklist
Affected core subsystem(s)
doc