doc: fix incorrect api version for Buffer.allocUnsafeSlow - #15392
Closed
jwgoh wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
|
Hi, @jwgoh! Thank you for the contribution! Unfortunately, there is already a PR that addresses this issue: #15330 I am sorry we have not removed the good first contribution label when that PR had emerged. I hope you will not be discouraged and will make other contributions! |
Sorry, something went wrong.
jasnell
approved these changes
Sep 13, 2017
Copy link
Copy Markdown
Member
|
This likely does not need to wait the 48 hours to land. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@jasnell It seems we have 2 PRs for this issue now. |
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
No worries @vsemozhetbyt, my bad, off to the next issue! |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
heh... I thought it had looked familiar :-) |
Sorry, something went wrong.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #15279
Checklist
Affected core subsystem(s)
doc