FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: patch V8 to 6.1.534.38 by MylesBorins · Pull Request #15431 · nodejs/node · GitHub

/ node Public

deps: patch V8 to 6.1.534.38 - #15431

Closed
MylesBorins wants to merge 1 commit into
nodejs:masterfrom
MylesBorins:update-6.1-lkgr
ConversationCommits (1)ChecksFiles changed
Closed

deps: patch V8 to 6.1.534.38#15431
MylesBorins wants to merge 1 commit into
nodejs:masterfrom
MylesBorins:update-6.1-lkgr

Conversation

MylesBorins commented Sep 15, 2017

Copy link
Copy Markdown
Contributor

created using the update-v8 npm module and the command

update-v8 minor

I've reviewed the patch and can confirm it contains all changes
from 6.1.534.36 -> 6.1.534.38

nodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label Sep 15, 2017
deps: patch V8 to 6.1.534.38
1839833 
created using the update-v8 npm module and the command

`update-v8 minor`

I've reviewed the patch and can confirm it contains all changes
from 6.1.534.36 -> 6.1.534.38

MylesBorins commented Sep 15, 2017

Copy link
Copy Markdown
Contributor Author

This should be cherry-picked to #15393

addaleax mentioned this pull request Sep 15, 2017
Closed
2 tasks
jasnell approved these changes Sep 15, 2017
View reviewed changes

jasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

rubber stamp LGTM

MylesBorins commented Sep 15, 2017

Copy link
Copy Markdown
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/10096/

v8-ci: https://ci.nodejs.org/job/node-test-commit-v8-linux/907/

fhinkel approved these changes Sep 16, 2017
View reviewed changes
Comment thread deps/v8/include/v8-version.h
#define V8_MINOR_VERSION 1
#define V8_BUILD_NUMBER 534
#define V8_PATCH_LEVEL 36
#define V8_PATCH_LEVEL 38

fhinkel Sep 16, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Is there another open patch going to 37?

targos Sep 16, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

the change in flag-definitions.h is the patch 37

MylesBorins Sep 16, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

exactly. This patch includes both 37 + 38

fhinkel commented Sep 16, 2017

Copy link
Copy Markdown
Contributor

Restarted the CI:
https://ci.nodejs.org/job/node-test-pull-request/10110/
https://ci.nodejs.org/job/node-test-commit-v8-linux/908/

gibfahn commented Sep 17, 2017

Copy link
Copy Markdown
Member

Maybe worth including the upstream hashes:

v8/v8@35b4f6e
v8/v8@eeb87aa

targos commented Sep 18, 2017

Copy link
Copy Markdown
Member

I usually include the compare link: v8/v8@6.1.534.36...6.1.534.38

targos commented Sep 18, 2017

Copy link
Copy Markdown
Member

Landed in 9b996f0.

targos closed this Sep 18, 2017
targos pushed a commit that referenced this pull request Sep 18, 2017
deps: patch V8 to 6.1.534.38
9b996f0 
Created using the update-v8 npm module and the command
`update-v8 minor`.

Refs: v8/v8@6.1.534.36...6.1.534.38

PR-URL: #15431
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
targos pushed a commit to targos/node that referenced this pull request Sep 21, 2017
deps: patch V8 to 6.1.534.38
133b51d 
Created using the update-v8 npm module and the command
`update-v8 minor`.

Refs: v8/v8@6.1.534.36...6.1.534.38

PR-URL: nodejs#15431
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Qard pushed a commit to Qard/ayo that referenced this pull request Sep 21, 2017
deps: patch V8 to 6.1.534.38
ef1c2b6 
Created using the update-v8 npm module and the command
`update-v8 minor`.

Refs: v8/v8@6.1.534.36...6.1.534.38

PR-URL: nodejs/node#15431
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Qard pushed a commit to Qard/ayo that referenced this pull request Sep 21, 2017
deps: patch V8 to 6.1.534.38
04f6659 
Created using the update-v8 npm module and the command
`update-v8 minor`.

Refs: v8/v8@6.1.534.36...6.1.534.38

PR-URL: nodejs/node#15431
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins added a commit that referenced this pull request Sep 28, 2017
deps: patch V8 to 6.1.534.38
1da78cd 
Created using the update-v8 npm module and the command
`update-v8 minor`.

Refs: v8/v8@6.1.534.36...6.1.534.38

Backport-PR-URL: #15393
PR-URL: #15431
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins added a commit that referenced this pull request Sep 29, 2017
deps: patch V8 to 6.1.534.38
f290e5d 
Created using the update-v8 npm module and the command
`update-v8 minor`.

Refs: v8/v8@6.1.534.36...6.1.534.38

Backport-PR-URL: #15393
PR-URL: #15431
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins mentioned this pull request Oct 3, 2017
Merged
MylesBorins added a commit that referenced this pull request Oct 3, 2017
deps: patch V8 to 6.1.534.38
8471747 
Created using the update-v8 npm module and the command
`update-v8 minor`.

Refs: v8/v8@6.1.534.36...6.1.534.38

Backport-PR-URL: #15393
PR-URL: #15431
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins deleted the update-6.1-lkgr branch November 14, 2017 17:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
addaleax addaleax approved these changes
+4 more reviewers
targos targos approved these changes
ofrobots ofrobots approved these changes
fhinkel fhinkel approved these changes
gibfahn gibfahn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL