FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v8.x backport] test,process: run 'abort' suite on Windows by refack · Pull Request #15460 · nodejs/node · GitHub

/ node Public

[v8.x backport] test,process: run 'abort' suite on Windows - #15460

Closed
refack wants to merge 2 commits into
nodejs:v8.x-stagingfrom
refack:v8-backport-15056
Closed

[v8.x backport] test,process: run 'abort' suite on Windows#15460
refack wants to merge 2 commits into
nodejs:v8.x-stagingfrom
refack:v8-backport-15056

Conversation

refack commented Sep 18, 2017
edited
Loading

Copy link
Copy Markdown
Contributor

PR-URL: #15056

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test,build

nodejs-github-bot added build Issues and PRs related to build files or the CI. v8.x windows Issues and PRs related to the Windows platform. labels Sep 18, 2017
refack added the test Issues and PRs related to the tests. label Sep 18, 2017

refack commented Sep 18, 2017

Copy link
Copy Markdown
Contributor Author

PR-URL: nodejs#15056
Fixes: nodejs#14012
Refs: nodejs#14013
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

refack commented Sep 23, 2017
edited
Loading

Copy link
Copy Markdown
Contributor Author

CI: https://ci.nodejs.org/job/node-test-commit/12556/ ✔️
(single windows failure is #15558)

jasnell commented Sep 25, 2017

Copy link
Copy Markdown
Member

Landed in v8.x-staging

jasnell closed this Sep 25, 2017
refack deleted the v8-backport-15056 branch October 24, 2017 13:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to build files or the CI. test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL