FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: extend timeouts for ARMv6 by rvagg · Pull Request #1554 · nodejs/node · GitHub

/ node Public

test: extend timeouts for ARMv6 - #1554

Closed
rvagg wants to merge 0 commit into
nodejs:masterfrom
rvagg:pi-timeouts
ConversationCommits (0)ChecksFiles changed
Closed

test: extend timeouts for ARMv6#1554
rvagg wants to merge 0 commit into
nodejs:masterfrom
rvagg:pi-timeouts

Conversation

rvagg commented Apr 29, 2015

Copy link
Copy Markdown
Member

Background: I suspect the ARMv6 timeouts introduced by @silverwind were based on a Pi B+ or similar or perhaps an overclocked Pi. The CI cluster has 2 x original Pi's and 1 x Pi B+ and the tests don't consistently pass on the older Pi's.

This configuration gives me all passes but I'd appreciate review by @silverwind and anyone else familiar with the specific tests I've adjusted: test-child-process-fork-net2.js, test-debug-signal-cluster.js, test-next-tick-error-spin.js

mscdex added the test Issues and PRs related to the tests. label Apr 29, 2015

silverwind commented Apr 29, 2015

Copy link
Copy Markdown
Contributor

The x6 factor was already very generous, it surprises me a bit that you still have issues. I suspect your SD must be of a very slow kind or something.

LGTM, if it helps.

rvagg commented Apr 29, 2015

Copy link
Copy Markdown
Member Author

could be .. one of the Pi's particularly has an older SD card. An alternative to raising it to 7 is going through the individual tests that have been failing and extending them rather than doing the whole lot.

jbergstroem commented Apr 29, 2015

Copy link
Copy Markdown
Member

I went through ccache statistics on all the PI's. They have a very high hitrate – so getting faster storage would probably be the best solution :/

silverwind commented Apr 29, 2015

Copy link
Copy Markdown
Contributor

If I remember correctly, the RPi doesn't have a dedicated storage controller, so all SD access is done on the CPU, which puts a hard limit on the transfer rate you can get. I'm fine with x7 myself.

rvagg added a commit that referenced this pull request Apr 29, 2015
test: extend timeouts for ARMv6
f9b226c 
Based on tests running on original Raspberry Pi

PR-URL: #1554
Reviewed-By: Roman Reiss <me@silverwind.io>
rvagg closed this Apr 29, 2015

rvagg commented Apr 29, 2015

Copy link
Copy Markdown
Member Author

f9b226c

rvagg deleted the pi-timeouts branch April 29, 2015 09:29
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request Apr 29, 2015
test: extend timeouts for ARMv6
fe08db9 
Based on tests running on original Raspberry Pi

PR-URL: nodejs#1554
Reviewed-By: Roman Reiss <me@silverwind.io>
rvagg mentioned this pull request May 2, 2015
Closed
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request May 14, 2015
test: extend timeouts for ARMv6
32a6dbc 
Based on tests running on original Raspberry Pi

PR-URL: nodejs#1554
PORT-PR-URL: nodejs#1560
PORT-FROM: v2.x / f9b226c
Reviewed-By: Roman Reiss <me@silverwind.io>
Fishrock123 mentioned this pull request May 14, 2015
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL