FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v8.x] deps: update npm to 5.4.2 by targos · Pull Request #15600 · nodejs/node · GitHub

/ node Public

[v8.x] deps: update npm to 5.4.2 - #15600

Closed
targos wants to merge 1 commit into
nodejs:v8.x-stagingfrom
targos:npm-5.4.2-v8.x
ConversationCommits (1)ChecksFiles changed
Closed

[v8.x] deps: update npm to 5.4.2#15600
targos wants to merge 1 commit into
nodejs:v8.x-stagingfrom
targos:npm-5.4.2-v8.x

Conversation

targos commented Sep 25, 2017

Copy link
Copy Markdown
Member

This includes three npm releases, one of which is pretty big (5.4.0).

Changes of Note

  • Significant performance boost for installations from cache (~10%+)
  • A number of bugfixes for important and severe bugs affecting
    installation on all supported platforms, but particularly noticeable
    on Windows.
  • More Windows-related fixes for npx.
  • #17844
    Make package-lock.json sorting locale-agnostic. This will cause
    some users to see seemingly spurious diffs on their pkglocks if
    they were using previous versions of npm5, because, for example,
    JSONStream is sorted into a different location. This is fine and
    will go away as people upgrade.

Changelogs

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

targos added the npm Issues and PRs related to the npm client dependency or the npm registry. label Sep 25, 2017
targos mentioned this pull request Sep 25, 2017
Closed
2 tasks

bzoz commented Sep 25, 2017

Copy link
Copy Markdown
Contributor

Looks like this will fix #15095

targos added the notable-change PRs with changes that should be highlighted in changelogs. label Sep 25, 2017

bricss commented Sep 25, 2017

Copy link
Copy Markdown
Contributor

I can confirm that it will definitely fix #15095

bricss mentioned this pull request Sep 25, 2017
Merged

gibfahn commented Sep 25, 2017

Copy link
Copy Markdown
Member

cc/ @nodejs/npm , would be good to get @zkat and @iarna to give this a look (AIUI it's #15486 (comment) but for 8.x).

@targos did you manage to run make test-npm on this? It should work on Darwin/Linux, but in my experience (not up to date) you get the odd test failure.

targos commented Sep 25, 2017

Copy link
Copy Markdown
Member Author

@gibfahn make test-npm seems to block on

> npm@5.4.2 test-node /home/mzasso/git/nodejs/node-v8/test-npm
> tap --timeout 240 "test/tap/*.js" "test/network/*.js" "test/broken-under-nyc*/*.js"

Reading TAP data from stdin (use "-" argument to suppress)

CPU is not working

gibfahn commented Sep 25, 2017

Copy link
Copy Markdown
Member

You could try the js one:

./node tools/test-npm-package --install deps/npm test

Or I could just land #11540 and we could run it through CI. Really needs some more reviews, but 🤷‍♂️ .

FWIW that output usually means that tap didn't find any files. Chances are the directory didn't get set up properly, you can just look through the bash script, it just copies deps/npm to test-npm and then does an npm install && npm test on it.

targos commented Sep 25, 2017

Copy link
Copy Markdown
Member Author

I tried test-npm-package and manual run. Both also hang. It's weird because I don't have this issue with a fresh clone of the npm repo.

iarna commented Sep 26, 2017

Copy link
Copy Markdown
Member

I'm ok with 5.4.2 going in (previous 5.4 releases weren't stable enough for me to feel comfortable).

I'll take a look at the tests, this should be pretty straight forward. The blocking happens when tap is given an empty list of tests (it falls back to reading them from STDIN, which results in the process never doing anything).

michaeljota mentioned this pull request Sep 27, 2017
Closed

gibfahn commented Sep 30, 2017

Copy link
Copy Markdown
Member

@targos the version of npm in your PR doesn't seem to have a test directory, which I assume is why the test is hanging.

See https://github.com/targos/node/tree/npm-5.4.2-v8.x/deps/npm
cf: https://github.com/nodejs/node/tree/master/deps/npm

targos commented Sep 30, 2017

Copy link
Copy Markdown
Member Author

OK. That makes sense... Then the issue is that npm doesn't include the test directory anymore in the release tarball.

targos commented Sep 30, 2017

Copy link
Copy Markdown
Member Author

This is because the version of npm-packlist present in npm 5.4.2 ignores the test directory. This has been reverted in npm/npm-packlist#3 and should be OK in the next version of npm.
@iarna do you know when the release is scheduled?

deps: update npm to 5.4.2
1d79870 
This includes three npm releases, one of which is pretty big (5.4.0).

Changes of Note

* Significant performance boost for installations from cache (~10%+)
* A number of bugfixes for important and severe bugs affecting
  installation on all supported platforms, but particularly noticeable
  on Windows.
* More Windows-related fixes for `npx`.
* [nodejs#17844](npm/npm#17844)
  Make package-lock.json sorting locale-agnostic. This will cause
  some users to see seemingly spurious diffs on their pkglocks if
  they were using previous versions of npm5, because, for example,
  `JSONStream` is sorted into a different location. This is fine and
  will go away as people upgrade.

Changelogs

* [`v5.4.0`](https://github.com/npm/npm/releases/tag/v5.4.0)
* [`v5.4.1`](https://github.com/npm/npm/releases/tag/v5.4.1)
* [`v5.4.2`](https://github.com/npm/npm/releases/tag/v5.4.2)

MylesBorins commented Oct 3, 2017

Copy link
Copy Markdown
Contributor

landed in 547fe58

MylesBorins closed this Oct 3, 2017
MylesBorins added a commit that referenced this pull request Oct 11, 2017
2017-10-11, Node.js Version 8.7.0 (Current)
dc4f1b9 
Notable Changes:

* deps:
  * update npm to 5.4.2
    #15600
  * upgrade libuv to 1.15.0
    #15745
  * update V8 to 6.1.534.42
    #15393
* dgram:
  * support for setting dgram socket buffer size
    #13623
* fs:
  * add support O_DSYNC file open constant
    #15451
* util:
  * deprecate obj.inspect for custom inspection
    #15631
* tools, build:
  * there is a fancy new macOS installer
    #15179
* Added new collaborator
  * bmeurer - Benedikt Meurer - https://github.com/bmeurer
  * kfarnung - Kyle Farnung - https://github.com/kfarnung

PR-URL: #15762
MylesBorins mentioned this pull request Oct 11, 2017
Merged
MylesBorins added a commit that referenced this pull request Oct 11, 2017
2017-10-11, Node.js Version 8.7.0 (Current)
b7fec86 
Notable Changes:

* deps:
  * update npm to 5.4.2
    #15600
  * upgrade libuv to 1.15.0
    #15745
  * update V8 to 6.1.534.42
    #15393
* dgram:
  * support for setting dgram socket buffer size
    #13623
* fs:
  * add support O_DSYNC file open constant
    #15451
* util:
  * deprecate obj.inspect for custom inspection
    #15631
* tools, build:
  * there is a fancy new macOS installer
    #15179
* Added new collaborator
  * bmeurer - Benedikt Meurer - https://github.com/bmeurer
  * kfarnung - Kyle Farnung - https://github.com/kfarnung

PR-URL: #15762
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 12, 2017
2017-10-11, Node.js Version 8.7.0 (Current)
4b1e46b 
Notable Changes:

* deps:
  * update npm to 5.4.2
    nodejs/node#15600
  * upgrade libuv to 1.15.0
    nodejs/node#15745
  * update V8 to 6.1.534.42
    nodejs/node#15393
* dgram:
  * support for setting dgram socket buffer size
    nodejs/node#13623
* fs:
  * add support O_DSYNC file open constant
    nodejs/node#15451
* util:
  * deprecate obj.inspect for custom inspection
    nodejs/node#15631
* tools, build:
  * there is a fancy new macOS installer
    nodejs/node#15179
* Added new collaborator
  * bmeurer - Benedikt Meurer - https://github.com/bmeurer
  * kfarnung - Kyle Farnung - https://github.com/kfarnung

PR-URL: nodejs/node#15762
targos deleted the npm-5.4.2-v8.x branch October 23, 2017 12:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

notable-change PRs with changes that should be highlighted in changelogs. npm Issues and PRs related to the npm client dependency or the npm registry.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL