FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

url: significantly improve the performance of the url module by petkaantonov · Pull Request #1561 · nodejs/node · GitHub

/ node Public

url: significantly improve the performance of the url module - #1561

Closed
petkaantonov wants to merge 1 commit into
nodejs:masterfrom
petkaantonov:faster-url-parser
ConversationCommits (1)ChecksFiles changed
Closed

url: significantly improve the performance of the url module#1561
petkaantonov wants to merge 1 commit into
nodejs:masterfrom
petkaantonov:faster-url-parser

Conversation

petkaantonov commented Apr 29, 2015

Copy link
Copy Markdown
Contributor

New PR to target master

This was referenced Apr 29, 2015
Closed
Closed
petkaantonov added the semver-major PRs that contain breaking changes and should be released in the next major version. label Apr 29, 2015
petkaantonov added this to the 2.0.0 milestone Apr 29, 2015

Fishrock123 commented Apr 29, 2015

Copy link
Copy Markdown
Contributor

CI: https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/636/

piscisaureus commented Apr 29, 2015

Copy link
Copy Markdown
Contributor

@petkaantonov Is this ready to land in your mind?

petkaantonov commented Apr 29, 2015

Copy link
Copy Markdown
Contributor Author

@piscisaureus yes although @domenic might want to check it out

domenic commented Apr 29, 2015

Copy link
Copy Markdown
Contributor

LGTM!

jbergstroem commented Apr 30, 2015

Copy link
Copy Markdown
Member

Very happy about getting the WhatWG tests in. Great job both @petkaantonov and all diligent reviewers.

Fishrock123 commented May 2, 2015

Copy link
Copy Markdown
Contributor

Original PR for posterity: #933

domenic commented May 2, 2015

Copy link
Copy Markdown
Contributor

What is this waiting on before it can be merged? Nothing, right?

petkaantonov added a commit that referenced this pull request May 2, 2015
url: significantly improve the performance of the url module
3fd7fc4 
(landed by @rvagg)

PR-URL: #1561
Reviewed-By: Domenic Denicola <domenic@domenicdenicola.com>
Reviewed-By: Rod Vagg <rod@vagg.org>

rvagg commented May 2, 2015

Copy link
Copy Markdown
Member

took the liberty of landing this, I hope you don't mind @petkaantonov. 3fd7fc4

rvagg closed this May 2, 2015
This was referenced May 2, 2015
Closed
Closed
isaacs mentioned this pull request May 3, 2015
Merged
othiym23 mentioned this pull request May 5, 2015
Closed
Fishrock123 mentioned this pull request Jun 10, 2015
Closed
Fishrock123 mentioned this pull request Jul 30, 2015
Closed
STRML mentioned this pull request Aug 5, 2015
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

semver-major PRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Milestone

2.0.0

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL