FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: update fs.utimes{,Sync} changelog by lpinca · Pull Request #15680 · nodejs/node · GitHub

/ node Public

doc: update fs.utimes{,Sync} changelog - #15680

Closed
lpinca wants to merge 1 commit into
nodejs:masterfrom
lpinca:gh-15453
Closed

doc: update fs.utimes{,Sync} changelog#15680
lpinca wants to merge 1 commit into
nodejs:masterfrom
lpinca:gh-15453

Conversation

lpinca commented Sep 29, 2017

Copy link
Copy Markdown
Member

Specify that NaN, Infinity, and -Infinity are no longer valid
values for the atime and mtime arguments.

Fixes: #15453

Checklist
Affected core subsystem(s)

doc

Specify that `NaN`, `Infinity`, and `-Infinity` are no longer valid
values for the `atime` and `mtime` arguments.

Fixes: nodejs#15453
nodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Sep 29, 2017

BridgeAR commented Oct 2, 2017

Copy link
Copy Markdown
Member

Landed in c8a2143

BridgeAR closed this Oct 2, 2017
BridgeAR pushed a commit that referenced this pull request Oct 2, 2017
Specify that `NaN`, `Infinity`, and `-Infinity` are no longer valid
values for the `atime` and `mtime` arguments.

PR-URL: #15680
Fixes: #15453
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
lpinca deleted the gh-15453 branch October 2, 2017 05:29
MylesBorins pushed a commit that referenced this pull request Oct 3, 2017
Specify that `NaN`, `Infinity`, and `-Infinity` are no longer valid
values for the `atime` and `mtime` arguments.

PR-URL: #15680
Fixes: #15453
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins mentioned this pull request Oct 3, 2017
MylesBorins pushed a commit that referenced this pull request Oct 3, 2017
Specify that `NaN`, `Infinity`, and `-Infinity` are no longer valid
values for the `atime` and `mtime` arguments.

PR-URL: #15680
Fixes: #15453
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
lpinca added a commit to lpinca/node that referenced this pull request Oct 4, 2017
Fixes YAML parsing issues introduced in c8a2143.

Refs: nodejs#15680
lpinca mentioned this pull request Oct 4, 2017
2 tasks
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 4, 2017
Specify that `NaN`, `Infinity`, and `-Infinity` are no longer valid
values for the `atime` and `mtime` arguments.

PR-URL: nodejs/node#15680
Fixes: nodejs/node#15453
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

vsemozhetbyt commented Oct 5, 2017
edited
Loading

Copy link
Copy Markdown
Contributor

This PR possibly breaks doc building.

Refs:
#15447
#14930 (comment)

lpinca commented Oct 5, 2017
edited
Loading

Copy link
Copy Markdown
Member Author

@vsemozhetbyt #15769 has enough LGTMs and it's a trivial change. Feel free to land it if you have time.

Copy link
Copy Markdown
Contributor

Fixing PR: #15788

Copy link
Copy Markdown
Contributor

Oops, sorry, did not see that, I will close mine and land yours,

vsemozhetbyt pushed a commit that referenced this pull request Oct 5, 2017
Fixes YAML parsing issues introduced in c8a2143.

PR-URL: #15769
Refs: #15680
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 7, 2017
Fixes YAML parsing issues introduced in c8a2143.

PR-URL: #15769
Refs: #15680
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 11, 2017
Specify that `NaN`, `Infinity`, and `-Infinity` are no longer valid
values for the `atime` and `mtime` arguments.

PR-URL: #15680
Fixes: #15453
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Oct 11, 2017
Fixes YAML parsing issues introduced in c8a2143.

PR-URL: #15769
Refs: #15680
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 12, 2017
Fixes YAML parsing issues introduced in c8a2143.

PR-URL: nodejs/node#15769
Refs: nodejs/node#15680
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fs.utimes Infinity support is misdocumented or regressed

7 participants


Back | FazBrowse Home | New Git URL