FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

http2: incremental improvements by jasnell · Pull Request #15693 · nodejs/node · GitHub

/ node Public

http2: incremental improvements - #15693

Closed
jasnell wants to merge 4 commits into
nodejs:masterfrom
jasnell:http2-incremental-improvements
ConversationCommits (4)ChecksFiles changed
Closed

http2: incremental improvements#15693
jasnell wants to merge 4 commits into
nodejs:masterfrom
jasnell:http2-incremental-improvements

Conversation

jasnell commented Sep 29, 2017

Copy link
Copy Markdown
Member

Several different bits in here. All incremental improvements.

The last commit in the bunch (making sending to the socket more efficient) should be reviewed carefully to make sure it's not introducing any sneaky bugs.

@nodejs/http2

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

http2

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Sep 29, 2017
mscdex added the http2 Issues or PRs related to the http2 subsystem. label Sep 29, 2017
mcollina approved these changes Oct 2, 2017
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

jasnell commented Oct 2, 2017

Copy link
Copy Markdown
Member Author

@apapirovski ... can I ask you to take a look over this and test it against your express test suite?

jasnell commented Oct 2, 2017

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/10382/

apapirovski approved these changes Oct 2, 2017
View reviewed changes

apapirovski left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM! Also no change in express & on-finished test results when applied over top of my compatibility changes.

jasnell added a commit that referenced this pull request Oct 2, 2017
http2: simplify TypeName
8fa0247 
PR-URL: #15693
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
jasnell added a commit that referenced this pull request Oct 2, 2017
http2: refactor method arguments to avoid bools
8f4db31 
PR-URL: #15693
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
jasnell added a commit that referenced this pull request Oct 2, 2017
http2: eliminate dead code
8691d8b 
PR-URL: #15693
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
jasnell added a commit that referenced this pull request Oct 2, 2017
http2: making sending to the socket more efficient
7092a6c 
PR-URL: #15693
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

jasnell commented Oct 2, 2017

Copy link
Copy Markdown
Member Author

Landed in 8fa0247, 8f4bd31, 8691d8b and 7092a6c

jasnell closed this Oct 2, 2017
MylesBorins pushed a commit that referenced this pull request Oct 3, 2017
http2: simplify TypeName
f10e2f5 
PR-URL: #15693
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins pushed a commit that referenced this pull request Oct 3, 2017
http2: refactor method arguments to avoid bools
470ef86 
PR-URL: #15693
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins pushed a commit that referenced this pull request Oct 3, 2017
http2: eliminate dead code
7611ed5 
PR-URL: #15693
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins pushed a commit that referenced this pull request Oct 3, 2017
http2: making sending to the socket more efficient
93f3d25 
PR-URL: #15693
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins mentioned this pull request Oct 3, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Oct 3, 2017
http2: simplify TypeName
18dbcf2 
PR-URL: #15693
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins pushed a commit that referenced this pull request Oct 3, 2017
http2: refactor method arguments to avoid bools
420139f 
PR-URL: #15693
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins pushed a commit that referenced this pull request Oct 3, 2017
http2: eliminate dead code
e5feb7d 
PR-URL: #15693
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins pushed a commit that referenced this pull request Oct 3, 2017
http2: making sending to the socket more efficient
a8020bf 
PR-URL: #15693
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 4, 2017
http2: simplify TypeName
6095084 
PR-URL: nodejs/node#15693
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 4, 2017
http2: refactor method arguments to avoid bools
df1dc28 
PR-URL: nodejs/node#15693
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 4, 2017
http2: making sending to the socket more efficient
d483ca3 
PR-URL: nodejs/node#15693
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 4, 2017
http2: eliminate dead code
be1b184 
PR-URL: nodejs/node#15693
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins pushed a commit that referenced this pull request Oct 11, 2017
http2: simplify TypeName
86ee05d 
PR-URL: #15693
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins pushed a commit that referenced this pull request Oct 11, 2017
http2: refactor method arguments to avoid bools
078ee27 
PR-URL: #15693
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins pushed a commit that referenced this pull request Oct 11, 2017
http2: eliminate dead code
68cd233 
PR-URL: #15693
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins pushed a commit that referenced this pull request Oct 11, 2017
http2: making sending to the socket more efficient
86dfcc6 
PR-URL: #15693
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
+1 more reviewer
apapirovski apapirovski approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem. lib / src Issues and PRs related to general changes in the lib or src directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL