doc: change encoding to decoding - #15706
Closed
thefourtheye wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
As per the example, `querystring.parse` actually does URL decoding, not encoding.
TimothyGu
approved these changes
Oct 1, 2017
Comment thread
doc/api/deprecations.md
|
|
||
| *Note*: This function is not completely equivalent to `querystring.parse()`. One | ||
| difference is that `querystring.parse()` does url encoding: | ||
| difference is that `querystring.parse()` does url decoding: |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Nit: s/does url/attempts URL/
Sorry, something went wrong.
jasnell
approved these changes
Oct 1, 2017
lpinca
approved these changes
Oct 1, 2017
addaleax
approved these changes
Oct 1, 2017
cjihrig
approved these changes
Oct 2, 2017
hiroppy
approved these changes
Oct 2, 2017
jasnell
pushed a commit
that referenced
this pull request
Oct 2, 2017
As per the example, `querystring.parse` actually does URL decoding, not encoding. PR-URL: #15706 Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 3, 2017
As per the example, `querystring.parse` actually does URL decoding, not encoding. PR-URL: #15706 Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Oct 3, 2017
As per the example, `querystring.parse` actually does URL decoding, not encoding. PR-URL: #15706 Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Oct 4, 2017
As per the example, `querystring.parse` actually does URL decoding, not encoding. PR-URL: nodejs/node#15706 Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 11, 2017
As per the example, `querystring.parse` actually does URL decoding, not encoding. PR-URL: #15706 Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per the example, querystring.parse actually does URL decoding, not
encoding.
Checklist
Affected core subsystem(s)
doc