FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

url: const-ify first argument of ToUnicode function by lpinca · Pull Request #15725 · nodejs/node · GitHub

/ node Public

url: const-ify first argument of ToUnicode function - #15725

Closed
lpinca wants to merge 1 commit into
nodejs:masterfrom
lpinca:constify/input-arg
Closed

url: const-ify first argument of ToUnicode function#15725
lpinca wants to merge 1 commit into
nodejs:masterfrom
lpinca:constify/input-arg

Conversation

lpinca commented Oct 2, 2017

Copy link
Copy Markdown
Member

Fixes a compiler error on Windows.

Refs: #15615 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

url

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v4.x whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Oct 2, 2017

lpinca commented Oct 2, 2017

Copy link
Copy Markdown
Member Author

Closing in favor of #15724.

lpinca closed this Oct 2, 2017
lpinca deleted the constify/input-arg branch October 2, 2017 07:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. whatwg-url Issues and PRs related to the WHATWG URL implementation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL