test: mark test-bindings and test-debug-end flaky - #15747
Conversation
Sorry, something went wrong.
Trott
left a comment
There was a problem hiding this comment.
No objections to fast-tracking.
Sorry, something went wrong.
|
CI: https://ci.nodejs.org/job/node-test-pull-request/10390/ (all green) |
Sorry, something went wrong.
|
I'm landing and putting a calendar reminder to follow up every week. |
Sorry, something went wrong.
PR-URL: #15747 Refs: #15558 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
|
@joaocgreis do we have a VS2017 config for node-stress-single-test? |
Sorry, something went wrong.
PR-URL: nodejs/node#15747 Refs: nodejs/node#15558 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
|
@refack now we do. No cross compiling support yet, so only Windows 2008R2 and 2012R2. I started some test runs, Windows 2012 does not seem to be affected but 2008 is. Note: mp and 1p are for multiple and single virtual processor machines, in the past this made a big difference for some tests (concurrency issues tent to appear much more often in 1p, but compiling node is much faster in mp). |
Sorry, something went wrong.
PR-URL: #15747 Refs: #15558 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
|
Oy what a mess 100 OK: 0 NOT OK: 100 TOTAL: 100 |
Sorry, something went wrong.
PR-URL: #15747 Refs: #15558 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
|
This does not land cleanly in LTS. Please feel free to manually backport by following the guide. Please also feel free to replace do-not-land if it is being backported |
Sorry, something went wrong.
test-bindings and test-debug-end have been failing frequently on Windows. For now, just mark them flaky, this can be reverted when a solution is found.
Ref: #15558
Any objections for fast tracking this?
cc @nodejs/testing @nodejs/v8-inspector
Checklist
Affected core subsystem(s)
test