test: test-tls-fast-writing replace common.fixturesDir - #15808
Closed
bthallion wants to merge 0 commit into
Closed
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
rmg
approved these changes
Oct 6, 2017
cjihrig
reviewed
Oct 7, 2017
Comment thread
test/parallel/test-tls-fast-writing.js
Outdated
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
common should be the first thing require()'ed.
Sorry, something went wrong.
Copy link
Copy Markdown
Author
There was a problem hiding this comment.
I've fixed this
Sorry, something went wrong.
benjamingr
approved these changes
Oct 7, 2017
benjamingr
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM with the nit addressed.
Sorry, something went wrong.
lpinca
approved these changes
Oct 9, 2017
gibfahn
reviewed
Oct 9, 2017
Comment thread
test/parallel/test-tls-fast-writing.js
Outdated
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
If you replace the three readFileSyncs (e.g. fs.readFileSync(${dir}/test_ca.pem) with fixtures.readSync('test_ca.pem')) you can remove the const dir line, and probably the require('fs') as well, although make lint will tell you that.
If you could push a commit to your branch making that change that'd be great!
Docs here: https://github.com/nodejs/node/tree/master/test/common#fixturesreadsyncargs-enc
Sorry, something went wrong.
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Oct 15, 2017
Replace common.fixturesDir with fixtures module usage in test/parallel/test-tls-fast-writing.js. PR-URL: nodejs#15808 Reviewed-By: Ryan Graham <r.m.graham@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Copy link
Copy Markdown
Member
|
Landed in 2b76b5d. |
Sorry, something went wrong.
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 15, 2017
Replace common.fixturesDir with fixtures module usage in test/parallel/test-tls-fast-writing.js. PR-URL: nodejs/node#15808 Reviewed-By: Ryan Graham <r.m.graham@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 18, 2017
Replace common.fixturesDir with fixtures module usage in test/parallel/test-tls-fast-writing.js. PR-URL: #15808 Reviewed-By: Ryan Graham <r.m.graham@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 16, 2017
Replace common.fixturesDir with fixtures module usage in test/parallel/test-tls-fast-writing.js. PR-URL: #15808 Reviewed-By: Ryan Graham <r.m.graham@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 21, 2017
Replace common.fixturesDir with fixtures module usage in test/parallel/test-tls-fast-writing.js. PR-URL: #15808 Reviewed-By: Ryan Graham <r.m.graham@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 28, 2017
Replace common.fixturesDir with fixtures module usage in test/parallel/test-tls-fast-writing.js. PR-URL: #15808 Reviewed-By: Ryan Graham <r.m.graham@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In test-tls-fast-writing I used the common/fixtures module to reference fixturesDir rather than the common/index module
Checklist
Affected core subsystem(s)
test