test: use common/fixtures module instead of common.fixturesDir in tes… - #15811
Closed
CharlesWall wants to merge 1 commit into
Closed
test: use common/fixtures module instead of common.fixturesDir in tes…#15811CharlesWall wants to merge 1 commit into
CharlesWall wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
CharlesWall
force-pushed
the
use-common-fixtures-module
branch
from
d7c6a83 to
bfff470
Compare
October 6, 2017 16:50
Copy link
Copy Markdown
Contributor
Author
|
woot. I R Node. |
Sorry, something went wrong.
pawelgolda
reviewed
Oct 6, 2017
Comment thread
test/parallel/test-https-localaddress.js
Outdated
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
This could be using method fixtures.readKey instead of fixtures.readSync to get the keys.
Sorry, something went wrong.
CharlesWall
force-pushed
the
use-common-fixtures-module
branch
from
bfff470 to
c961334
Compare
October 6, 2017 19:59
rmg
approved these changes
Oct 6, 2017
rmg
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks great! Thanks for helping make Node.js more awesome :-D
Sorry, something went wrong.
benjamingr
approved these changes
Oct 7, 2017
cjihrig
approved these changes
Oct 7, 2017
tniessen
approved these changes
Oct 7, 2017
lpinca
reviewed
Oct 9, 2017
Comment thread
test/parallel/test-https-localaddress.js
Outdated
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Nit: can you please move this after the common.skip() conditions?
Sorry, something went wrong.
…t/parallel/test-https-localaddress.js
CharlesWall
force-pushed
the
use-common-fixtures-module
branch
from
c961334 to
802359f
Compare
October 9, 2017 17:14
jasnell
approved these changes
Oct 9, 2017
gireeshpunathil
approved these changes
Oct 10, 2017
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Failures in CI are unrelated to this change. |
Sorry, something went wrong.
jasnell
pushed a commit
that referenced
this pull request
Oct 12, 2017
PR-URL: #15811 Reviewed-By: Ryan Graham <r.m.graham@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 15, 2017
PR-URL: nodejs/node#15811 Reviewed-By: Ryan Graham <r.m.graham@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
targos
pushed a commit
that referenced
this pull request
Oct 18, 2017
PR-URL: #15811 Reviewed-By: Ryan Graham <r.m.graham@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
targos
pushed a commit
that referenced
this pull request
Oct 18, 2017
PR-URL: #15811 Reviewed-By: Ryan Graham <r.m.graham@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 15, 2017
PR-URL: #15811 Reviewed-By: Ryan Graham <r.m.graham@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 21, 2017
PR-URL: #15811 Reviewed-By: Ryan Graham <r.m.graham@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 28, 2017
PR-URL: #15811 Reviewed-By: Ryan Graham <r.m.graham@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…t/parallel/test-https-localaddress.js
Checklist
Affected core subsystem(s)