FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: make use of common/fixtures.fixturesDir by jemjam · Pull Request #15815 · nodejs/node · GitHub

/ node Public

test: make use of common/fixtures.fixturesDir - #15815

Closed
jemjam wants to merge 2 commits into
nodejs:masterfrom
jemjam:change-test
ConversationCommits (2)ChecksFiles changed
Closed

test: make use of common/fixtures.fixturesDir#15815
jemjam wants to merge 2 commits into
nodejs:masterfrom
jemjam:change-test

Conversation

jemjam commented Oct 6, 2017 •
edited
Loading

Copy link
Copy Markdown

The common/fixtures module provides convenience methods for working with
files in the test/fixtures directory. Make use of the fixturesDir
value from module rather than value from common.

  • Replace common.fixtures with fixtures.fixturesDir
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

test: make use of common/fixtures.fixturesDir
78c2b1e 
The common/fixtures module provides convenience methods for working with
files in the test/fixtures directory. Make use of the `fixturesDir`
value from module rather than value from common.

- Replace `common.fixtures` with `fixtures.fixturesDir`
nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 6, 2017
mscdex added the crypto Issues and PRs related to the crypto subsystem. label Oct 6, 2017
Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 7, 2017
lpinca reviewed Oct 9, 2017
View reviewed changes
Comment thread test/pummel/test-crypto-timing-safe-equal-benchmarks.js Outdated
@@ -1,5 +1,6 @@
'use strict';
const common = require('../common');
const fixtures = require('../common/fixtures');

lpinca Oct 9, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nit: would you mind to move this after the common.skip() conditions?

jemjam Oct 9, 2017

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'd love to. 👍

tniessen approved these changes Oct 9, 2017
View reviewed changes

tniessen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, would be great if you could address @lpinca's comment.

gireeshpunathil commented Oct 12, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/10649/

jasnell pushed a commit that referenced this pull request Oct 13, 2017
test: make use of common/fixtures.fixturesDir
c4231aa 
The common/fixtures module provides convenience methods for working with
files in the test/fixtures directory. Make use of the `fixturesDir`
value from module rather than value from common.

- Replace `common.fixtures` with `fixtures.fixturesDir`

PR-URL: #15815
Reviewed-By: Ryan Graham <r.m.graham@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell commented Oct 13, 2017

Copy link
Copy Markdown
Member

Landed in c4231aa

jasnell closed this Oct 13, 2017
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 15, 2017
test: make use of common/fixtures.fixturesDir
6006c45 
The common/fixtures module provides convenience methods for working with
files in the test/fixtures directory. Make use of the `fixturesDir`
value from module rather than value from common.

- Replace `common.fixtures` with `fixtures.fixturesDir`

PR-URL: nodejs/node#15815
Reviewed-By: Ryan Graham <r.m.graham@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Oct 18, 2017
test: make use of common/fixtures.fixturesDir
529e685 
The common/fixtures module provides convenience methods for working with
files in the test/fixtures directory. Make use of the `fixturesDir`
value from module rather than value from common.

- Replace `common.fixtures` with `fixtures.fixturesDir`

PR-URL: #15815
Reviewed-By: Ryan Graham <r.m.graham@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
test: make use of common/fixtures.fixturesDir
1cd910b 
The common/fixtures module provides convenience methods for working with
files in the test/fixtures directory. Make use of the `fixturesDir`
value from module rather than value from common.

- Replace `common.fixtures` with `fixtures.fixturesDir`

PR-URL: #15815
Reviewed-By: Ryan Graham <r.m.graham@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
test: make use of common/fixtures.fixturesDir
f223800 
The common/fixtures module provides convenience methods for working with
files in the test/fixtures directory. Make use of the `fixturesDir`
value from module rather than value from common.

- Replace `common.fixtures` with `fixtures.fixturesDir`

PR-URL: #15815
Reviewed-By: Ryan Graham <r.m.graham@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
test: make use of common/fixtures.fixturesDir
57590cd 
The common/fixtures module provides convenience methods for working with
files in the test/fixtures directory. Make use of the `fixturesDir`
value from module rather than value from common.

- Replace `common.fixtures` with `fixtures.fixturesDir`

PR-URL: #15815
Reviewed-By: Ryan Graham <r.m.graham@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
benjamingr benjamingr approved these changes
lpinca lpinca approved these changes
tniessen tniessen approved these changes
gireeshpunathil gireeshpunathil approved these changes
+1 more reviewer
rmg rmg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. crypto Issues and PRs related to the crypto subsystem. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Back | FazBrowse Home | New Git URL