FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: update 'fixturesDir' refs in a test file by JamesMGreene · Pull Request #15824 · nodejs/node · GitHub

/ node Public

test: update 'fixturesDir' refs in a test file - #15824

Closed
JamesMGreene wants to merge 1 commit into
nodejs:masterfrom
JamesMGreene:cnl_first_task
ConversationCommits (1)ChecksFiles changed
Closed

test: update 'fixturesDir' refs in a test file#15824
JamesMGreene wants to merge 1 commit into
nodejs:masterfrom
JamesMGreene:cnl_first_task

Conversation

JamesMGreene commented Oct 6, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

This was a task from Code & Learn at NINA17.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Thanks @jasnell 💝

nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 6, 2017
pawelgolda reviewed Oct 6, 2017
View reviewed changes
Comment thread test/parallel/test-http-url.parse-https.request.js Outdated

pawelgolda Oct 6, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This could be using method fixtures.readKey instead of fs.readFileSync to get the keys.

JamesMGreene Oct 6, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Good call. I followed the distributed Code & Learn task description pretty literally, so this thought never occurred to me. Thanks for the tip. 👍

JamesMGreene Oct 6, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

P.S. Updated with another commit.

tniessen commented Oct 6, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/10425/

test: update 'fixturesDir' refs in a test file
86727f6 
This was a task from Code & Learn at NINA17.

JamesMGreene commented Oct 6, 2017

Copy link
Copy Markdown
Contributor Author

I've squashed the commits for this.

rmg approved these changes Oct 6, 2017
View reviewed changes

rmg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This looks great! Thanks for contributing!

mscdex added the http Issues or PRs related to the http subsystem. label Oct 6, 2017
Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 6, 2017

refack commented Oct 6, 2017

Copy link
Copy Markdown
Contributor

Welcome @JamesMGreene and thank you for the contribution 🥇

Resumed the CI jobs that failed because of git issues:
https://ci.nodejs.org/job/node-test-commit/12825/

JamesMGreene commented Oct 6, 2017

Copy link
Copy Markdown
Contributor Author

Thanks for the resume, @refack. 👍

refack self-assigned this Oct 6, 2017
refack pushed a commit that referenced this pull request Oct 7, 2017
test: update 'fixturesDir' refs in a test file
1c97fa7 
This was a task from Code & Learn at NINA17.

PR-URL: #15824
Reviewed-By: Ryan Graham <r.m.graham@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

refack commented Oct 7, 2017

Copy link
Copy Markdown
Contributor

Landed in 1c97fa7
@JamesMGreene congratulations on being promoted from:

to

refack closed this Oct 7, 2017

JamesMGreene commented Oct 8, 2017

Copy link
Copy Markdown
Contributor Author

\o/ :tada:

And thank you in turn to all of the Node.js collaborators and NINA17 mentors for allowing us the opportunity for an “easy in”. 👍

JamesMGreene commented Oct 8, 2017

Copy link
Copy Markdown
Contributor Author

I know it’s a lot more work on your end than just doing it yourselves but it’s a brilliant way to get new contributors involved.

MylesBorins pushed a commit that referenced this pull request Oct 11, 2017
test: update 'fixturesDir' refs in a test file
516fda6 
This was a task from Code & Learn at NINA17.

PR-URL: #15824
Reviewed-By: Ryan Graham <r.m.graham@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins mentioned this pull request Oct 11, 2017
Merged
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 12, 2017
test: update 'fixturesDir' refs in a test file
f9da2da 
This was a task from Code & Learn at NINA17.

PR-URL: nodejs/node#15824
Reviewed-By: Ryan Graham <r.m.graham@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins pushed a commit that referenced this pull request Nov 14, 2017
test: update 'fixturesDir' refs in a test file
667cbd7 
This was a task from Code & Learn at NINA17.

PR-URL: #15824
Reviewed-By: Ryan Graham <r.m.graham@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
test: update 'fixturesDir' refs in a test file
ae61adf 
This was a task from Code & Learn at NINA17.

PR-URL: #15824
Reviewed-By: Ryan Graham <r.m.graham@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
test: update 'fixturesDir' refs in a test file
14aee78 
This was a task from Code & Learn at NINA17.

PR-URL: #15824
Reviewed-By: Ryan Graham <r.m.graham@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
refack removed their assignment Oct 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

benjamingr benjamingr approved these changes
cjihrig cjihrig approved these changes
tniessen tniessen approved these changes
richardlau richardlau approved these changes
+3 more reviewers
pawelgolda pawelgolda left review comments
rmg rmg approved these changes
refack refack approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Back | FazBrowse Home | New Git URL