FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: replaces fixturesDir with fixtures by alireza-a · Pull Request #15838 · nodejs/node · GitHub

/ node Public

test: replaces fixturesDir with fixtures - #15838

Closed
alireza-a wants to merge 2 commits into
nodejs:masterfrom
alireza-a:test-fixture-inspector
ConversationCommits (2)ChecksFiles changed
Closed

test: replaces fixturesDir with fixtures#15838
alireza-a wants to merge 2 commits into
nodejs:masterfrom
alireza-a:test-fixture-inspector

Conversation

alireza-a commented Oct 6, 2017

Copy link
Copy Markdown
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 6, 2017
rmg reviewed Oct 6, 2017
View reviewed changes

rmg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for helping make Node.js better!

Comment thread test/parallel/test-inspector-invalid-args.js Outdated

rmg Oct 6, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

What do you think about using fixtures.path('loop.js') to replace path.join(..., 'loop.js') and make this even simpler?

alireza-a Oct 7, 2017

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

done. thank you!

Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 6, 2017
mscdex added the inspector Issues and PRs related to the V8 inspector protocol label Oct 6, 2017

alireza-a commented Oct 7, 2017

Copy link
Copy Markdown
Author

should I squash the commits?

joyeecheung commented Oct 8, 2017

Copy link
Copy Markdown
Member

@alireza-a You can do that, or whoever lands this will take care of it.

gibfahn commented Oct 8, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-commit/12907/

joyeecheung commented Oct 10, 2017

Copy link
Copy Markdown
Member

Landed in 7ba896e, thanks for the contribution!

joyeecheung pushed a commit that referenced this pull request Oct 10, 2017
test: replaces fixturesDir with fixtures
7ba896e 
PR-URL: #15838
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 11, 2017
test: replaces fixturesDir with fixtures
b1e6373 
PR-URL: #15838
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
MylesBorins mentioned this pull request Oct 11, 2017
Merged
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 12, 2017
test: replaces fixturesDir with fixtures
e1dfd92 
PR-URL: nodejs/node#15838
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
joyeecheung joyeecheung approved these changes
+2 more reviewers
rmg rmg left review comments
gibfahn gibfahn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. inspector Issues and PRs related to the V8 inspector protocol test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL