test: rewrite assert message - #15879
Closed
mgjm wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
`test/parallel/test-zlib-unzip-one-byte-chunks.js` uses a literal string to describe the error if the string does not match itself after zipping and unzipping. Changed to a more descriptive template literal.
Trott
reviewed
Oct 8, 2017
Trott
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Sorry, something went wrong.
jasnell
approved these changes
Oct 10, 2017
tniessen
approved these changes
Oct 10, 2017
lpinca
approved these changes
Oct 10, 2017
Copy link
Copy Markdown
Member
|
Landed in adbc5d7. Thanks for the contribution! 🎉 |
Sorry, something went wrong.
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Oct 11, 2017
`test/parallel/test-zlib-unzip-one-byte-chunks.js` uses a literal string to describe the error if the string does not match itself after zipping and unzipping. Changed to a more descriptive template literal. PR-URL: nodejs#15879 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Oct 12, 2017
`test/parallel/test-zlib-unzip-one-byte-chunks.js` uses a literal string to describe the error if the string does not match itself after zipping and unzipping. Changed to a more descriptive template literal. PR-URL: nodejs/node#15879 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 18, 2017
`test/parallel/test-zlib-unzip-one-byte-chunks.js` uses a literal string to describe the error if the string does not match itself after zipping and unzipping. Changed to a more descriptive template literal. PR-URL: #15879 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 15, 2017
`test/parallel/test-zlib-unzip-one-byte-chunks.js` uses a literal string to describe the error if the string does not match itself after zipping and unzipping. Changed to a more descriptive template literal. PR-URL: #15879 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 21, 2017
`test/parallel/test-zlib-unzip-one-byte-chunks.js` uses a literal string to describe the error if the string does not match itself after zipping and unzipping. Changed to a more descriptive template literal. PR-URL: #15879 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 28, 2017
`test/parallel/test-zlib-unzip-one-byte-chunks.js` uses a literal string to describe the error if the string does not match itself after zipping and unzipping. Changed to a more descriptive template literal. PR-URL: #15879 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test/parallel/test-zlib-unzip-one-byte-chunks.js uses a literal
string to describe the error if the string does not match itself
after zipping and unzipping. Changed to a more descriptive template
literal.
Checklist
Affected core subsystem(s)