clarify assertion failure - #15889
Closed
ryshep111 wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Hi, @ryshep111! Welcome and thanks for this! This change will cause the linter to fail. Try make lint-js (or vcbuild lint-js) to see the problem. Can you update your branch to fix this? |
Sorry, something went wrong.
BridgeAR
approved these changes
Oct 9, 2017
Comment thread
test/pummel/test-tls-connect-memleak.js
| typeof global.gc, | ||
| 'function', | ||
| 'Run this test with --expose-gc' | ||
| `Type of global.gc is not a function. Type: ${typeof global.gc}. Run this test with --expose-gc` |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I will fix this while landing.
Sorry, something went wrong.
BridgeAR
pushed a commit
that referenced
this pull request
Oct 9, 2017
PR-URL: #15889 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Copy link
Copy Markdown
Member
|
Landed in 92d3269 Thanks for the PR, and congratulations on becoming a Node.js Contributor 🎉 ! |
Sorry, something went wrong.
MylesBorins
pushed a commit
that referenced
this pull request
Oct 11, 2017
PR-URL: #15889 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Oct 12, 2017
PR-URL: nodejs/node#15889 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
assertion failure messages should always give the actual and expected results.