Also, this appears to have other changes mixed in (notably the libuv upgrade commit) that need to be removed first.

@colin-tucows this PR seems to have somehow picked up a commit that was already in master.

If you are comfortable enough with git to update your branch to remove that commit then great, otherwise I think that can be cleared up on landing.

hi @gibfahn ,

sorry, i will need more guidance on what you mean by 'update your branch to remove that commit' and/or how i should fix this pr. i don't know why commit 75318e4 got mixed up with my pr.

if you prefer to just clean-up this pr for me on landing, that is fine with me too.

thanks,
colin

@gibfahn Judging from that mysterious time-travelling ghost comment from Rich, I guess this could be the Github bug came haunting us again.

@colin-tucows I have fixed the commits (with the commit message fixed to follow our commit message guidelines)

@colin-tucows Also in case you want to know how I fixed it, here are the commands that I used (the "allow edits from maintainer" box is checked in this PR so that is why I can force-push to your fork)

git remote add ct git@github.com:colin-tucows/node.git
git fetch ct master
git checkout -b ct-master
git reset --hard ct/master
git rebase master -i
git branch --set-upstream-to=ct/master
git push --force ct HEAD:master

CI: https://ci.nodejs.org/job/node-test-pull-request/10496/

Landed in d00bb87

Thanks for the PR, and congratulations on becoming a Node.js Contributor 🎉 !