test: replace fixturesDir with fixtures in https agent create connect… - #15913
Closed
Greg-GB wants to merge 2 commits into
Closed
test: replace fixturesDir with fixtures in https agent create connect…#15913Greg-GB wants to merge 2 commits into
Greg-GB wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
watilde
previously requested changes
Oct 6, 2017
Comment thread
test/parallel/test-https-agent-create-connection.js
Outdated
| const options = { | ||
| key: fs.readFileSync(`${common.fixturesDir}/keys/agent1-key.pem`), | ||
| cert: fs.readFileSync(`${common.fixturesDir}/keys/agent1-cert.pem`), | ||
| key: fixtures.readSync('keys/agent1-key.pem'), |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I think we also can use fixtures.readKey.
Sorry, something went wrong.
gibfahn
approved these changes
Oct 7, 2017
Copy link
Copy Markdown
Member
|
CI: https://ci.nodejs.org/job/node-test-commit/12856/ EDIT: CI was green |
Sorry, something went wrong.
cjihrig
approved these changes
Oct 7, 2017
Copy link
Copy Markdown
Member
|
Landing... |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@Greg-GB congratulations on becoming a Node.js contributor! |
Sorry, something went wrong.
gibfahn
pushed a commit
that referenced
this pull request
Oct 7, 2017
PR-URL: #15913 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Oct 11, 2017
PR-URL: #15913 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Oct 12, 2017
PR-URL: nodejs/node#15913 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 14, 2017
PR-URL: #15913 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 21, 2017
PR-URL: #15913 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 28, 2017
PR-URL: #15913 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ion test
Replace fixturesDir with common.fixtures module and removed unused fs module.
Checklist
Affected core subsystem(s)
test