test: replace common.fixturesDir with common.fixtures in test-debugger-debug-brk - #15919
Closed
penDerGraft wants to merge 5 commits into
Closed
test: replace common.fixturesDir with common.fixtures in test-debugger-debug-brk#15919penDerGraft wants to merge 5 commits into
penDerGraft wants to merge 5 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
penDerGraft
commented
Oct 6, 2017
Comment thread
test/sequential/test-debugger-debug-brk.js
|
|
||
| const script = `${common.fixturesDir}/empty.js`; | ||
| // file name here doesn't actually matter since | ||
| // debugger will connect regardless of file name arg |
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
I was confused why the test was passing regardless of the file name so I added this comment. Talked with @Trott about this. Happy to remove if this is common knowledge!
Sorry, something went wrong.
benjamingr
approved these changes
Oct 7, 2017
benjamingr
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks for your contribution!
Sorry, something went wrong.
BridgeAR
approved these changes
Oct 9, 2017
Trott
approved these changes
Oct 9, 2017
Copy link
Copy Markdown
Member
Sorry, something went wrong.
tniessen
approved these changes
Oct 9, 2017
BridgeAR
pushed a commit
that referenced
this pull request
Oct 9, 2017
PR-URL: #15919 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Copy link
Copy Markdown
Member
|
Landed in 261ae7f Thanks for the PR, and congratulations on becoming a Node.js Contributor 🎉 ! |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Thanks everybody! |
Sorry, something went wrong.
MylesBorins
pushed a commit
that referenced
this pull request
Oct 11, 2017
PR-URL: #15919 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Oct 12, 2017
PR-URL: nodejs/node#15919 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)