test: replace common.fixturesDir with fixtures - #15946
Closed
AshleyRayMaceli wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
pawelgolda
reviewed
Oct 6, 2017
Comment thread
test/parallel/test-http2-https-fallback.js
Outdated
|
|
||
| function loadKey(keyname) { | ||
| return readFileSync(join(common.fixturesDir, 'keys', keyname)); | ||
| return readFileSync(join(fixtures.fixturesDir, 'keys', keyname)); |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
This could be using method fixtures.readKey to get the keys.
Sorry, something went wrong.
BridgeAR
approved these changes
Oct 7, 2017
Copy link
Copy Markdown
Member
|
The commit message has to be changed to include the subsystem. This can be done while landing though. |
Sorry, something went wrong.
cjihrig
approved these changes
Oct 7, 2017
Copy link
Copy Markdown
Member
Sorry, something went wrong.
joyeecheung
approved these changes
Oct 8, 2017
gibfahn
pushed a commit
that referenced
this pull request
Oct 8, 2017
PR-URL: #15946 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Copy link
Copy Markdown
Member
|
Landed in 86d803b Thanks for the PR, and congratulations on becoming a Node.js Contributor 🎉 ! |
Sorry, something went wrong.
MylesBorins
pushed a commit
that referenced
this pull request
Oct 11, 2017
PR-URL: #15946 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Merged
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Oct 12, 2017
PR-URL: nodejs/node#15946 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task: replace common.fixturesDir with fixtures
Checklist
Affected core subsystem(s)