FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: replace common.fixturesDir with the fixtures module by weiplanet · Pull Request #16027 · nodejs/node · GitHub

/ node Public

test: replace common.fixturesDir with the fixtures module - #16027

Closed
weiplanet wants to merge 1 commit into
nodejs:masterfrom
weiplanet:master
ConversationCommits (1)ChecksFiles changed
Closed

test: replace common.fixturesDir with the fixtures module #16027
weiplanet wants to merge 1 commit into
nodejs:masterfrom
weiplanet:master

Conversation

weiplanet commented Oct 6, 2017 •
edited by BridgeAR
Loading

Copy link
Copy Markdown
Contributor

Replace common.fixturesDir with use of the common.fixtures module

Checklist
Subsystem

test

nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 6, 2017
mhdawson approved these changes Oct 6, 2017
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

mscdex added the http Issues or PRs related to the http subsystem. label Oct 6, 2017
Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 6, 2017
benjamingr reviewed Oct 7, 2017
View reviewed changes
Comment thread test/parallel/test-http-default-port.js
const fs = require('fs');
const path = require('path');
const fixtures = path.join(common.fixturesDir, 'keys');
const fixtures = path.join(fixturesModule.fixturesDir, 'keys');

benjamingr Oct 7, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This can be a fixures.path('keys')

cjihrig Oct 7, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think a better change would be to update the fs.readFileSync() calls a few lines later to use the fixture keys call.

jasnell Oct 10, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

For instance...

const options = {
  key: fixtures.readSync('agent1-key.pem'),
  cert: fixtures.readSync('agent1-cert.pem')
};

refack self-assigned this Oct 10, 2017

joyeecheung commented Oct 11, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/10622/

lpinca approved these changes Oct 14, 2017
View reviewed changes
Comment thread test/parallel/test-http-default-port.js

'use strict';
const common = require('../common');
const fixturesModule = require('../common/fixtures');

lpinca Oct 14, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nit: this could/should be moved after the common.hasCrypto check.

joyeecheung commented Oct 14, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

Landed in 1a9f48a with #16027 (review) and #16027 (review) fixed. Thank you for the contribution!

joyeecheung pushed a commit that referenced this pull request Oct 14, 2017
test: replace fixturesDir with the fixtures module
1a9f48a 
PR-URL: #16027
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 15, 2017
test: replace fixturesDir with the fixtures module
d6b06ec 
PR-URL: nodejs/node#16027
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
targos pushed a commit that referenced this pull request Oct 18, 2017
test: replace fixturesDir with the fixtures module
8452af2 
PR-URL: #16027
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
test: replace fixturesDir with the fixtures module
81bb560 
PR-URL: #16027
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
MylesBorins mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
test: replace fixturesDir with the fixtures module
69882ad 
PR-URL: #16027
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
test: replace fixturesDir with the fixtures module
a28d666 
PR-URL: #16027
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
refack removed their assignment Oct 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell left review comments
cjihrig cjihrig left review comments
benjamingr benjamingr approved these changes
lpinca lpinca approved these changes
BridgeAR BridgeAR approved these changes
+2 more reviewers
hiroppy hiroppy approved these changes
mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Back | FazBrowse Home | New Git URL