FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: Add notes how addMembership should be managed by watilde · Pull Request #16240 · nodejs/node · GitHub

/ node Public

doc: Add notes how addMembership should be managed - #16240

Closed
watilde wants to merge 1 commit into
nodejs:masterfrom
watilde:feature/docs-dgram
ConversationCommits (1)ChecksFiles changed
Closed

doc: Add notes how addMembership should be managed#16240
watilde wants to merge 1 commit into
nodejs:masterfrom
watilde:feature/docs-dgram

Conversation

watilde commented Oct 16, 2017

Copy link
Copy Markdown
Member

Fixes: #12572

Checklist
Affected core subsystem(s)

doc, dgram

nodejs-github-bot added dgram Issues and PRs related to the dgram subsystem / UDP. doc Issues and PRs related to the documentations. labels Oct 16, 2017
lpinca reviewed Oct 17, 2017
View reviewed changes
Comment thread doc/api/dgram.md Outdated

lpinca Oct 17, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Does "worker" refer to a cluster environment? If so I think it makes sense to specify it as the sentence seems to be a bit out of context without it.

watilde Oct 22, 2017

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yes, it does and I agreed on it. I will add the context.

jasnell reviewed Oct 18, 2017
View reviewed changes
Comment thread doc/api/dgram.md Outdated

jasnell Oct 18, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Please avoid using the informal pronoun you in the docs :-)

watilde Oct 22, 2017

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Sure! I will update it.

watilde force-pushed the feature/docs-dgram branch from 1c7f640 to 5292a50 Compare October 22, 2017 09:36

watilde commented Oct 25, 2017

Copy link
Copy Markdown
Member Author

ci: https://ci.nodejs.org/job/node-test-pull-request/10975/

watilde closed this Nov 14, 2017
watilde deleted the feature/docs-dgram branch November 14, 2017 21:37

prog1dev commented Feb 2, 2018

Copy link
Copy Markdown
Contributor

@watilde Why did you close this pr?

gireeshpunathil commented Apr 29, 2018

Copy link
Copy Markdown
Member

ping @watilde - what happened here? the changes look reasonable. was it through an error you deleted the branch and closed the PR? are you planning to resurrect this?

jasnell added a commit to jasnell/node that referenced this pull request Oct 19, 2018
doc: document that addMembership must be called once in a cluster
08c277c 
Fixes: nodejs#12572
Refs: nodejs#16240
jasnell mentioned this pull request Oct 19, 2018
Closed
2 tasks
jasnell added a commit that referenced this pull request Oct 23, 2018
doc: document that addMembership must be called once in a cluster
30d42f6 
Fixes: #12572
Refs: #16240

PR-URL: #23746
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Oct 24, 2018
doc: document that addMembership must be called once in a cluster
83b776c 
Fixes: #12572
Refs: #16240

PR-URL: #23746
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 26, 2018
doc: document that addMembership must be called once in a cluster
67fa459 
Fixes: #12572
Refs: #16240

PR-URL: #23746
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 26, 2018
doc: document that addMembership must be called once in a cluster
64f9a3c 
Fixes: #12572
Refs: #16240

PR-URL: #23746
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 26, 2018
doc: document that addMembership must be called once in a cluster
56ba6ee 
Fixes: #12572
Refs: #16240

PR-URL: #23746
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
doc: document that addMembership must be called once in a cluster
96a4417 
Fixes: #12572
Refs: #16240

PR-URL: #23746
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
doc: document that addMembership must be called once in a cluster
32ae851 
Fixes: #12572
Refs: #16240

PR-URL: #23746
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
doc: document that addMembership must be called once in a cluster
a3362a7 
Fixes: #12572
Refs: #16240

PR-URL: #23746
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
doc: document that addMembership must be called once in a cluster
32df77c 
Fixes: #12572
Refs: #16240

PR-URL: #23746
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 26, 2018
doc: document that addMembership must be called once in a cluster
3c4949a 
Fixes: #12572
Refs: #16240

PR-URL: #23746
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
doc: document that addMembership must be called once in a cluster
5f5ab97 
Fixes: #12572
Refs: #16240

PR-URL: #23746
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BethGriggs pushed a commit that referenced this pull request Mar 7, 2019
doc: document that addMembership must be called once in a cluster
ad62971 
Fixes: #12572
Refs: #16240

PR-URL: #23746
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell left review comments
lpinca lpinca left review comments

Assignees

No one assigned

Labels

dgram Issues and PRs related to the dgram subsystem / UDP. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL