FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Revert "zlib: improve performance" by Trott · Pull Request #16280 · nodejs/node · GitHub

/ node Public

Revert "zlib: improve performance" - #16280

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:zlib-revert
ConversationCommits (1)ChecksFiles changed
Closed

Revert "zlib: improve performance"#16280
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:zlib-revert

Conversation

Trott commented Oct 18, 2017

Copy link
Copy Markdown
Member

This reverts commit add4b0a.

@MylesBorins

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

zlib

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Oct 18, 2017

Trott commented Oct 18, 2017

Copy link
Copy Markdown
Member Author

Fixes: #14161

This was referenced Oct 18, 2017
Closed
Closed

Trott commented Oct 18, 2017

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/10800/

mscdex commented Oct 18, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

Can't we just fix minizlib instead (which shouldn't be accessing internals anyway)?

addaleax commented Oct 18, 2017

Copy link
Copy Markdown
Member

@mscdex At least @iarna said that’s what most likely to happen, but it certainly hasn’t happened yet (and I didn’t have the time to look into a proper fix for all of this either), and Node 9 is moving closer … this revert doesn’t have to be permanent.

Trott commented Oct 18, 2017

Copy link
Copy Markdown
Member Author

Can't we just fix minizlib instead (which shouldn't be accessing internals anyway)?

@mscdex I'll be happy if this ends up being unnecessary and we can close it without landing.

mcollina approved these changes Oct 18, 2017
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM but we shouldn’t need this.

mcollina commented Oct 18, 2017

Copy link
Copy Markdown
Member

can you address #15625 in a separate commit that is easily backportable?

addaleax commented Oct 18, 2017

Copy link
Copy Markdown
Member

Actually, @iarna just wrote a comment on isaacs/node-tar#144 which reminded me that that PR exists and also solves the problem here, for node-tar & npm.

iarna commented Oct 18, 2017

Copy link
Copy Markdown
Member

I'll see if I can't wrangle the node-tar patch into a npm release this week.

refack commented Oct 18, 2017

Copy link
Copy Markdown
Contributor

Can't we just fix minizlib instead (which shouldn't be accessing internals anyway)?

that’s what most likely to happen, but it certainly hasn’t happened yet

I'll see if I can't wrangle the node-tar patch into a npm release this week.

Can we have a deadline for either this or a compatible npm release? Suggesting Mon 10/23, if node9+npm is still broke, let's land this?

jasnell commented Oct 18, 2017

Copy link
Copy Markdown
Member

I'm generally -1 on this but I'm not going to give it the big red X or block it from moving forward. As others have said, I'd prefer the userland fix instead.

Fishrock123 commented Oct 18, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

I don't think we should do this. We made a stance on this long enough ago and my understanding is minizlib violated those expectations somewhat recently, and is authored by someone who very well knows our expectations on these things.

Edit: in extension, if npm or subdependencies use that module, it is their fault if things break.

zkat commented Oct 19, 2017

Copy link
Copy Markdown
Contributor

heads-up: the next release of npm is going out tomorrow, and will include a new version of node-tar which should be compatible.

If y'all wanna try the patch out in the meantime, you can use $ npx npmc install to try it out in the npm canary.

targos commented Oct 21, 2017

Copy link
Copy Markdown
Member

I think the latest npm (5.5.1) still has version 4.0.1 of node-tar.

addaleax commented Oct 22, 2017

Copy link
Copy Markdown
Member

@zkat Nice, this seems to work. 🎉

targos commented Oct 23, 2017

Copy link
Copy Markdown
Member

@zkat do you know when that release of npm will be available?
@jasnell is preparing the release of Node 9.0.0 and it would be really nice to have it in (we are currently stuck with 5.3.0 on master)

jasnell commented Oct 23, 2017 via email

Copy link
Copy Markdown
Member

MylesBorins mentioned this pull request Oct 26, 2017
Closed
MylesBorins added a commit to MylesBorins/node that referenced this pull request Oct 27, 2017
deps: update npm to 5.5.1
439a8e1 
Closes: nodejs#16280
Fixes: nodejs#14161
MylesBorins added a commit that referenced this pull request Oct 30, 2017
deps: update npm to 5.5.1
0d7e4d2 
Closes: #16280

PR-URL: #16509
Fixes: #14161
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
jasnell pushed a commit that referenced this pull request Oct 30, 2017
deps: update npm to 5.5.1
8922bba 
Closes: #16280

PR-URL: #16509
Fixes: #14161
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Qard pushed a commit to ayojs/ayo that referenced this pull request Nov 2, 2017
deps: update npm to 5.5.1
ba243dd 
Closes: nodejs/node#16280

PR-URL: nodejs/node#16509
Fixes: nodejs/node#14161
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Qard pushed a commit to ayojs/ayo that referenced this pull request Nov 2, 2017
deps: update npm to 5.5.1
803e41e 
Closes: nodejs/node#16280

PR-URL: nodejs/node#16509
Fixes: nodejs/node#14161
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
deps: update npm to 5.5.1
9391afd 
Closes: nodejs/node#16280

PR-URL: nodejs/node#16509
Fixes: nodejs/node#14161
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Trott deleted the zlib-revert branch January 13, 2022 22:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
+1 more reviewer
refack refack approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Back | FazBrowse Home | New Git URL