FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: move test-cluster-debug-port to sequential by al-k21 · Pull Request #16292 · nodejs/node · GitHub

/ node Public

test: move test-cluster-debug-port to sequential - #16292

Closed
al-k21 wants to merge 1 commit into
nodejs:v6.x-stagingfrom
al-k21:test-cluster-debug-port
Closed

test: move test-cluster-debug-port to sequential #16292
al-k21 wants to merge 1 commit into
nodejs:v6.x-stagingfrom
al-k21:test-cluster-debug-port

Conversation

al-k21 commented Oct 18, 2017

Copy link
Copy Markdown

This test cannot be run in parallel, as it can conflict with other tests using the debug port. I suggest making this test sequential.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

This test cannot be run in parallel, as it can conflict with other tests
using the debug port.
nodejs-github-bot added test Issues and PRs related to the tests. v6.x labels Oct 18, 2017

gibfahn commented Oct 18, 2017

Copy link
Copy Markdown
Member

Note that this test has already been removed from master.

cc/ @nodejs/testing

mscdex added the cluster Issues and PRs related to the cluster subsystem. label Oct 19, 2017
MylesBorins pushed a commit that referenced this pull request Oct 19, 2017
This test cannot be run in parallel, as it can conflict with other tests
using the debug port.

PR-URL: #16292
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

Copy link
Copy Markdown
Contributor

landed in f65f691

MylesBorins pushed a commit that referenced this pull request Oct 19, 2017
This test cannot be run in parallel, as it can conflict with other tests
using the debug port.

PR-URL: #16292
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
MylesBorins mentioned this pull request Oct 19, 2017
MylesBorins pushed a commit that referenced this pull request Oct 25, 2017
This test cannot be run in parallel, as it can conflict with other tests
using the debug port.

PR-URL: #16292
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 25, 2017
This test cannot be run in parallel, as it can conflict with other tests
using the debug port.

PR-URL: #16292
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
MylesBorins mentioned this pull request Oct 25, 2017
MylesBorins pushed a commit that referenced this pull request Oct 26, 2017
This test cannot be run in parallel, as it can conflict with other tests
using the debug port.

PR-URL: #16292
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cluster Issues and PRs related to the cluster subsystem. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.


Back | FazBrowse Home | New Git URL