[backport 6.x] doc: fix types and description for dns.resolveTxt - #16316
Closed
tniessen wants to merge 1 commit into
Closed
[backport 6.x] doc: fix types and description for dns.resolveTxt#16316tniessen wants to merge 1 commit into
tniessen wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
silverwind
reviewed
Oct 19, 2017
Comment thread
doc/api/dns.md
Outdated
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
I don't think resolveAny was backported to v6.x, so this line probably has to go.
Sorry, something went wrong.
PR-URL: nodejs#15472 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
tniessen
force-pushed
the
backport-15472-to-v6.x
branch
from
f245ee3 to
2192ed7
Compare
October 20, 2017 09:13
Copy link
Copy Markdown
Member
Author
|
@silverwind Thank you, fixed! PTAL |
Sorry, something went wrong.
silverwind
approved these changes
Oct 20, 2017
jasnell
approved these changes
Oct 20, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR-URL: #15472