FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: make test-v8-serdes work without stdin by danbev · Pull Request #16382 · nodejs/node · GitHub

/ node Public

test: make test-v8-serdes work without stdin - #16382

Closed
danbev wants to merge 1 commit into
nodejs:masterfrom
danbev:test-v8-serdes_handle
ConversationCommits (1)ChecksFiles changed
Closed

test: make test-v8-serdes work without stdin #16382
danbev wants to merge 1 commit into
nodejs:masterfrom
danbev:test-v8-serdes_handle

Conversation

danbev commented Oct 22, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

If stdin was closed or referred to a file, this didn't work,
because it was accessed via file descriptor.

Instead, use another generic native object.

cherry-picked from ayojs/ayo#63

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 22, 2017

danbev commented Oct 22, 2017

Copy link
Copy Markdown
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/10901/

addaleax commented Oct 22, 2017

Copy link
Copy Markdown
Member

Just to mention it: ayojs/ayo@06a1e54 also fixes this but doesn’t require skipping anything … I think that should be fine to use here

danbev commented Oct 22, 2017

Copy link
Copy Markdown
Contributor Author

Just to mention it: ayojs/ayo@06a1e54 also fixes this but doesn’t require skipping anything … I think that should be fine to use here

Very nice! Any advice on the the correct procedure for including that so the proper credit and such is given? Thanks

addaleax commented Oct 22, 2017

Copy link
Copy Markdown
Member

@danbev Since it’s my commit – do whatever you want with it. :) Just cherry-picking it should be fine, but whatever gets you where the code needs to be works for me 😄

test: make test-v8-serdes work without stdin
d38a427 
If `stdin` was closed or referred to a file, this didn't work,
because it was accessed via file descriptor.

Instead, use another generic native object.

cherry-picked from ayojs/ayo#63
mscdex added the v8 engine Issues and PRs related to the V8 dependency. label Oct 22, 2017
danbev force-pushed the test-v8-serdes_handle branch from daefca6 to d38a427 Compare October 23, 2017 03:49

danbev commented Oct 23, 2017

Copy link
Copy Markdown
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/10917/

danbev changed the title test: check for _handle in test-v8-serdes.js test: make test-v8-serdes work without stdin Oct 23, 2017

danbev commented Oct 25, 2017

Copy link
Copy Markdown
Contributor Author

Landed in 70670b0

danbev closed this Oct 25, 2017
danbev deleted the test-v8-serdes_handle branch October 25, 2017 05:23
apapirovski referenced this pull request Oct 25, 2017
test: make test-v8-serdes work without stdin
70670b0 
If `stdin` was closed or referred to a file, this didn't work,
because it was accessed via file descriptor.

Instead, use another generic native object.

cherry-picked from ayojs/ayo#63

Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
cjihrig cjihrig approved these changes

Assignees

No one assigned

Labels

test Issues and PRs related to the tests. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL