net: fix timeout with null handle - #16489
Closed
apapirovski wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
CI seems good other than one persistently failing ARM machine (unrelated). |
Sorry, something went wrong.
addaleax
approved these changes
Oct 25, 2017
addaleax
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Yeah, I’d be good with pushing out 8.8.1 asap – after all, that was a security release.
@nodejs/release
Sorry, something went wrong.
jasnell
approved these changes
Oct 25, 2017
jasnell
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM, +1 for fast tracking a patch release as long as it's not done on friday :-)
Sorry, something went wrong.
cjihrig
approved these changes
Oct 25, 2017
refack
approved these changes
Oct 25, 2017
cjihrig
pushed a commit
that referenced
this pull request
Oct 25, 2017
This commit handles the case where _onTimeout is called with a null handle. Refs: #15791 Fixes: #16484 PR-URL: #16489 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
addaleax
referenced
this pull request
in addaleax/node-core-utils
Oct 25, 2017
i.e. make `get-metadata https://github.com/nodejs/node/pull/16489` work
cjihrig
pushed a commit
that referenced
this pull request
Oct 25, 2017
This commit handles the case where _onTimeout is called with a null handle. Refs: #15791 Fixes: #16484 PR-URL: #16489 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
cjihrig
added a commit
that referenced
this pull request
Oct 25, 2017
Notable changes:
* net:
- Fix timeout with null handle issue. This is a regression in
Node 8.8.0. #16489
Merged
apapirovski
added a commit
to apapirovski/node
that referenced
this pull request
Oct 25, 2017
This commit handles the case where _onTimeout is called with a null handle. Refs: nodejs#15791 Fixes: nodejs#16484 PR-URL: nodejs#16489 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
cjihrig
added a commit
that referenced
this pull request
Oct 25, 2017
Notable changes:
* net:
- Fix timeout with null handle issue. This is a regression in
Node 8.8.0. #16489
addaleax
referenced
this pull request
in addaleax/node-core-utils
Oct 26, 2017
i.e. make `get-metadata https://github.com/nodejs/node/pull/16489` work
joyeecheung
referenced
this pull request
in nodejs/node-core-utils
Oct 26, 2017
i.e. make `get-metadata https://github.com/nodejs/node/pull/16489` work
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 26, 2017
This commit handles the case where _onTimeout is called with a null handle. Refs: nodejs/node#15791 Fixes: nodejs/node#16484 PR-URL: nodejs/node#16489 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 26, 2017
Notable changes:
* net:
- Fix timeout with null handle issue. This is a regression in
Node 8.8.0. nodejs/node#16489
Copy link
Copy Markdown
Contributor
|
Should this be backported to v6.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label. |
Sorry, something went wrong.
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Dec 7, 2017
This commit handles the case where _onTimeout is called with a null handle. Refs: nodejs/node#15791 Fixes: nodejs/node#16484 PR-URL: nodejs/node#16489 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Dec 7, 2017
Notable changes:
* net:
- Fix timeout with null handle issue. This is a regression in
Node 8.8.0. nodejs/node#16489
apapirovski
added a commit
to apapirovski/node
that referenced
this pull request
Dec 12, 2017
This commit handles the case where _onTimeout is called with a null handle. Refs: nodejs#15791 Fixes: nodejs#16484 PR-URL: nodejs#16489 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
3 tasks
MylesBorins
pushed a commit
that referenced
this pull request
Dec 20, 2017
This commit handles the case where _onTimeout is called with a null handle. Backport-PR-URL: #16420 Refs: #15791 Fixes: #16484 PR-URL: #16489 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 2, 2018
This commit handles the case where _onTimeout is called with a null handle. Backport-PR-URL: #16420 Refs: #15791 Fixes: #16484 PR-URL: #16489 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Merged
johnfrench3
referenced
this pull request
in johnfrench3/core-utils-node
Nov 2, 2022
i.e. make `get-metadata https://github.com/nodejs/node/pull/16489` work
renawolford6
referenced
this pull request
in renawolford6/node-dev-build-core-utils
Nov 10, 2022
i.e. make `get-metadata https://github.com/nodejs/node/pull/16489` work
Developerarif2
referenced
this pull request
in Developerarif2/node-core-utils
Jan 27, 2023
i.e. make `get-metadata https://github.com/nodejs/node/pull/16489` work
gerkai
referenced
this pull request
in gerkai/node-core-utils-project-build
Jan 27, 2023
i.e. make `get-metadata https://github.com/nodejs/node/pull/16489` work
patrickm68
referenced
this pull request
in patrickm68/NodeJS-core-utils
Sep 14, 2023
i.e. make `get-metadata https://github.com/nodejs/node/pull/16489` work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems like there's a scenario where _onTimeout somehow gets called with _handle set to null. If anyone has any ideas on how this is possible then let me know so I can put together a better test than I have so far.
This might need to be expedited (< 48 hrs) and turned into 8.8.1? Not sure... 😔 😓 At least it's not LTS yet... *sigh*
Fixes: #16484
Refs: #15791
/cc @MylesBorins
Checklist
Affected core subsystem(s)
net, test