process: add emitExperimentalWarning function - #16497
Closed
codeman869 wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
mhdawson
approved these changes
Oct 25, 2017
mhdawson
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Seems reasonable to me to common this up. I'll look at using it for N-API if possible once it lands.
Sorry, something went wrong.
jasnell
previously approved these changes
Oct 26, 2017
Copy link
Copy Markdown
Member
|
Let's make this an internal function on internal/util rather than expose it on process. It does not need to be a public, general use API. |
Sorry, something went wrong.
codeman869
force-pushed
the
process/experimental
branch
from
8a2a34e to
720c9a8
Compare
October 26, 2017 17:42
Copy link
Copy Markdown
Contributor
Author
|
@jasnell I've moved the changes to internal/util. Let me know what you think |
Sorry, something went wrong.
jasnell
approved these changes
Nov 2, 2017
Copy link
Copy Markdown
Contributor
Author
|
@jasnell do we need any further approvals or anything else to land this PR? :) |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Adds a new emitExperimentalWarning function to internal/util to warn users that they are using an experimental feature and that feature can change at any time. Refs: nodejs#9036
codeman869
force-pushed
the
process/experimental
branch
from
720c9a8 to
81dc7ff
Compare
November 16, 2017 01:00
Copy link
Copy Markdown
Contributor
Author
|
Rebased commit off current master so hopefully CI would pass |
Sorry, something went wrong.
BridgeAR
approved these changes
Nov 23, 2017
Copy link
Copy Markdown
Member
Sorry, something went wrong.
targos
approved these changes
Nov 23, 2017
targos
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
landing...
Sorry, something went wrong.
targos
pushed a commit
that referenced
this pull request
Nov 23, 2017
Adds a new emitExperimentalWarning function to internal/util to warn users that they are using an experimental feature and that feature can change at any time. PR-URL: #16497 Refs: #9036 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
3 tasks
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
Adds a new emitExperimentalWarning function to internal/util to warn users that they are using an experimental feature and that feature can change at any time. PR-URL: #16497 Refs: #9036 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
Adds a new emitExperimentalWarning function to internal/util to warn users that they are using an experimental feature and that feature can change at any time. PR-URL: #16497 Refs: #9036 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
gibfahn
pushed a commit
that referenced
this pull request
Dec 19, 2017
Adds a new emitExperimentalWarning function to internal/util to warn users that they are using an experimental feature and that feature can change at any time. PR-URL: #16497 Refs: #9036 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Closed
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
Adds a new emitExperimentalWarning function to internal/util to warn users that they are using an experimental feature and that feature can change at any time. PR-URL: #16497 Refs: #9036 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds process.emitExperimentalWarning to inform users that they are
using an experimental feature and that feature can change at any time.
Modifies the ESM module loader warning to utilize the new function and
allows user code to intercept this warning through a setImmediate call.
Refs: #9036
Checklist
Affected core subsystem(s)
process, internal