FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v8.x] backport of #16158: lib: refactor stream_wrap by addaleax · Pull Request #16626 · nodejs/node · GitHub

/ node Public

[v8.x] backport of #16158: lib: refactor stream_wrap - #16626

Closed
addaleax wants to merge 2 commits into
nodejs:v8.x-stagingfrom
addaleax:backport-16158
ConversationCommits (2)ChecksFiles changed
Closed

[v8.x] backport of #16158: lib: refactor stream_wrap#16626
addaleax wants to merge 2 commits into
nodejs:v8.x-stagingfrom
addaleax:backport-16158

Conversation

addaleax commented Oct 30, 2017

Copy link
Copy Markdown
Member

lib: move _stream_wrap into internals
46dfca7 
This makes a subsequent possible deprecation easier.

PR-URL: nodejs#16158
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
lib: refactor wrap_js_stream for ES6/readability
7cab126 
PR-URL: nodejs#16158
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
nodejs-github-bot added build Issues and PRs related to build files or the CI. net Issues and PRs related to the net subsystem. stream Issues and PRs related to the stream subsystem. v8.x labels Oct 30, 2017
gibfahn pushed a commit that referenced this pull request Oct 30, 2017
lib: move _stream_wrap into internals
d55ea72 
This makes a subsequent possible deprecation easier.

PR-URL: #16158
Backport-PR-URL: #16626
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
gibfahn pushed a commit that referenced this pull request Oct 30, 2017
lib: refactor wrap_js_stream for ES6/readability
97c2301 
PR-URL: #16158
Backport-PR-URL: #16626
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
gibfahn pushed a commit that referenced this pull request Oct 31, 2017
lib: move _stream_wrap into internals
87fd5b7 
This makes a subsequent possible deprecation easier.

PR-URL: #16158
Backport-PR-URL: #16626
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
gibfahn pushed a commit that referenced this pull request Oct 31, 2017
lib: refactor wrap_js_stream for ES6/readability
ab0d7a6 
PR-URL: #16158
Backport-PR-URL: #16626
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

gibfahn commented Oct 31, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

Thanks Anna, landed in 87fd5b7 and ab0d7a6

gibfahn closed this Oct 31, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
gibfahn gibfahn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI. net Issues and PRs related to the net subsystem. stream Issues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL