backport: 11665 to v6 - #16667
Conversation
Sorry, something went wrong.
Including: * Move async *stat() functions to FillStatsArray() now used by the sync *stat() functions * Avoid creating fs.Stats instances for implicit async/sync *stat() calls used in various fs functions * Store reference to Float64Array data on C++ side for easier/faster access, instead of passing from JS to C++ on every async/sync *stat() call Backport-PR-URL: nodejs#11665 Fixes: nodejs#16496
Including: * Avoid regexp on non-Windows platforms when parsing the root of a path Backport-PR-URL: nodejs#11665
|
The original PR was Semver-Major, is this backport only semver-patch? Are there some other patches that might be able to be reverted that could fix this instead of landing the optimization? Have you tested across various versions of v6.x? Is there a version that works? Thanks for taking the time to do this port 🎉 |
Sorry, something went wrong.
This PR is also Semver-Major in the sense that fs.readFileSync now calls fs.fstat instead of fs.fstatSync internally.
Yes. See the following section.
I have tested the signedness of dev on many versions of 6.x. The dev signedness of fs.stat, introduced on #8515, is impacted on every version. The signedness of fs.statSync is fixed on #11522 and landed on 6.10.1. But fs.stat is still being impacted. There is some discussions on the signedness on #8515. So I have worked on another PR to give a hotfix: #16705. |
Sorry, something went wrong.
|
/cc @nodejs/lts can you please take a look |
Sorry, something went wrong.
|
@mscdex since the original optimizations were done by you, would you be able to review this? |
Sorry, something went wrong.
Backported #11665 to v6, should fix #16496.
The fs.realpath*() optimizations is not fully ported since v6 is lack of internal/querystring.
Any feedback is welcome.
Checklist
Affected core subsystem(s)