tools: set eslint comma-spacing to 'warn' - #1672
Closed
silverwind wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
LGTM. |
Sorry, something went wrong.
silverwind
added a commit
that referenced
this pull request
May 11, 2015
Certain cases with comments inside arrays or object literals fail to pass eslint's comma-spacing rule. This change sets the comma-spacing rule to the 'warn' level. Once eslint/eslint#2408 is resolved and released, this rule should be set back to 'error' level. PR-URL: #1672 Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
Copy link
Copy Markdown
Contributor
Author
|
Thanks, landed in f07b3b6. Also added a note to the commit message to restore the rule to error level once the root issue is resolved. |
Sorry, something went wrong.
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
May 19, 2015
Certain cases with comments inside arrays or object literals fail to pass eslint's comma-spacing rule. This change sets the comma-spacing rule to the 'warn' level. Once eslint/eslint#2408 is resolved and released, this rule should be set back to 'error' level. PR-URL: nodejs#1672 Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eslint takes comment as whitespace, resulting in code like
failing the linter. This change reduces the comma-spacing rule to a warning, making make lint pass. I also fixed some misc whitespace issues in .eslintrc.
encountered in: #1650
eslint issue: eslint/eslint#2408
cc: @yosuke-furukawa