test: move timing-sensitive test to sequential - #16775
Closed
Trott wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
test-https-server-keep-alive-timeout relies on server timeouts and whatnot that will be inherently unreliable on a busy host. The test fails when run with a high `-j` value and higher `--repeat` value passed to `tools/test.py`. Move the test to `sequential`.
Copy link
Copy Markdown
Contributor
|
Why does it fail? It's not using a shared port? If it's the setTimeout(), perhaps we should be using the platform timeout variable there? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
$ tools/test.py -j 96 --repeat 192 test/parallel/test-https-server-keep-alive-timeout.js
=== release test-https-server-keep-alive-timeout ===
Path: parallel/test-https-server-keep-alive-timeout
Mismatched <anonymous> function calls. Expected exactly 3, actual 1.
at Object.exports.mustCall (/Users/trott/io.js/test/common/index.js:490:10)
at serverKeepAliveTimeoutWithPipeline (/Users/trott/io.js/test/parallel/test-https-server-keep-alive-timeout.js:34:12)
at run (/Users/trott/io.js/test/parallel/test-https-server-keep-alive-timeout.js:28:11)
at _combinedTickCallback (internal/process/next_tick.js:131:7)
at process._tickCallback (internal/process/next_tick.js:180:9)
at Function.Module.runMain (module.js:684:11)
at startup (bootstrap_node.js:191:16)
at bootstrap_node.js:613:3
Command: out/Release/node /Users/trott/io.js/test/parallel/test-https-server-keep-alive-timeout.js
[00:12|% 100|+ 191|- 1]: Done
$
common.platformTimeout() doesn't help on anything other than Raspberry Pi and a few other things. For most hosts, it leaves the value untouched. It might have a small number of valid uses, but generally, we overuse it IMO. Most tests that use it should be in sequential or (better) be refactored to eliminate race conditions. |
Sorry, something went wrong.
cjihrig
approved these changes
Nov 5, 2017
gireeshpunathil
approved these changes
Nov 6, 2017
XadillaX
approved these changes
Nov 6, 2017
jasnell
approved these changes
Nov 6, 2017
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Nov 18, 2017
test-https-server-keep-alive-timeout relies on server timeouts and whatnot that will be inherently unreliable on a busy host. The test fails when run with a high `-j` value and higher `--repeat` value passed to `tools/test.py`. Move the test to `sequential`. PR-URL: nodejs#16775 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
test-https-server-keep-alive-timeout relies on server timeouts and whatnot that will be inherently unreliable on a busy host. The test fails when run with a high `-j` value and higher `--repeat` value passed to `tools/test.py`. Move the test to `sequential`. PR-URL: #16775 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
gibfahn
pushed a commit
that referenced
this pull request
Dec 19, 2017
test-https-server-keep-alive-timeout relies on server timeouts and whatnot that will be inherently unreliable on a busy host. The test fails when run with a high `-j` value and higher `--repeat` value passed to `tools/test.py`. Move the test to `sequential`. PR-URL: #16775 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: James M Snell <jasnell@gmail.com>
Closed
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
test-https-server-keep-alive-timeout relies on server timeouts and whatnot that will be inherently unreliable on a busy host. The test fails when run with a high `-j` value and higher `--repeat` value passed to `tools/test.py`. Move the test to `sequential`. PR-URL: #16775 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test-https-server-keep-alive-timeout relies on server timeouts and
whatnot that will be inherently unreliable on a busy host. The test
fails when run with a high -j value and higher --repeat value passed
to tools/test.py. Move the test to sequential.
Checklist
Affected core subsystem(s)
test https