FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

loader: test search module by clakech · Pull Request #16795 · nodejs/node · GitHub

/ node Public

loader: test search module - #16795

Closed
clakech wants to merge 1 commit into
nodejs:masterfrom
clakech:loaderSearchCoverage
ConversationCommits (1)ChecksFiles changed
Closed

loader: test search module#16795
clakech wants to merge 1 commit into
nodejs:masterfrom
clakech:loaderSearchCoverage

Conversation

clakech commented Nov 6, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX)

nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 6, 2017
mscdex added the esm Issues and PRs related to the ECMAScript Modules implementation. label Nov 6, 2017

joyeecheung commented Nov 7, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/11258/

1 similar comment

joyeecheung commented Nov 7, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/11258/

clakech commented Nov 7, 2017

Copy link
Copy Markdown
Contributor Author

@joyeecheung Hi, thanks for running the CI. The build is stuck since 5 hours. What should I do ?

Trott commented Nov 7, 2017

Copy link
Copy Markdown
Member

The build is stuck since 5 hours. What should I do ?

@clakech All the CI runs are done except an AIX host which only became available for this CI run about 10 minutes ago. Everything else passed, so I'm pretty sure the AIX host will pass too.

Trott commented Nov 7, 2017

Copy link
Copy Markdown
Member

I'm pretty sure the AIX host will pass too.

As my father used to say: "Famous last words..."

AIX failed, but it's unrelated. I opened an issue about the failure at #16859. Meanwhile, this can land.

Trott commented Nov 7, 2017

Copy link
Copy Markdown
Member

Meanwhile, this can land.

Er, well, it should stay up for another day or two before landing. But I mean, Ci is OK. (Of course if any changes are requested and made, we'll need to re-run CI.)

clakech commented Nov 10, 2017

Copy link
Copy Markdown
Contributor Author

hi @Trott, should we launch another CI build ? or it could land as is ?

joyeecheung commented Nov 12, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/11370/

jasnell pushed a commit that referenced this pull request Nov 12, 2017
loader: test search module
e0113ab 
PR-URL: #16795
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

jasnell commented Nov 12, 2017

Copy link
Copy Markdown
Member

Landed in e0113ab

jasnell closed this Nov 12, 2017
evanlucas pushed a commit that referenced this pull request Nov 13, 2017
loader: test search module
64a0c80 
PR-URL: #16795
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
evanlucas mentioned this pull request Nov 13, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 17, 2017
loader: test search module
dc14c25 
PR-URL: #16795
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
gibfahn mentioned this pull request Nov 21, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
lpinca lpinca approved these changes
cjihrig cjihrig approved these changes
gireeshpunathil gireeshpunathil approved these changes
+1 more reviewer
apapirovski apapirovski approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

esm Issues and PRs related to the ECMAScript Modules implementation. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Back | FazBrowse Home | New Git URL