FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

change common with fixtures as task of nodetodo by DamianLion · Pull Request #16809 · nodejs/node · GitHub

/ node Public

change common with fixtures as task of nodetodo - #16809

Closed
DamianLion wants to merge 1 commit into
nodejs:masterfrom
DamianLion:master
ConversationCommits (1)ChecksFiles changed
Closed

change common with fixtures as task of nodetodo#16809
DamianLion wants to merge 1 commit into
nodejs:masterfrom
DamianLion:master

Conversation

DamianLion commented Nov 6, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 6, 2017
mscdex added the repl Issues and PRs related to the REPL subsystem. label Nov 6, 2017

gireeshpunathil commented Nov 6, 2017

Copy link
Copy Markdown
Member

@DeltaLikeM - looks like you pushed changed without:

#git config --global user.name
#git config --global user.email

on your system - implication of which is that this commit will not be associated with your profile. Can you set them up and push once again?

gireeshpunathil reviewed Nov 6, 2017
View reviewed changes
Comment thread test/parallel/test-repl.js Outdated

gireeshpunathil Nov 6, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

this can be:
const moduleFilename = fixtures.path('a');

Trott force-pushed the master branch 3 times, most recently from f7fa5cd to ec8d9ca Compare November 6, 2017 16:17

Trott commented Nov 6, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/11229/

vsemozhetbyt commented Nov 6, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

Beware: Commit author is not associated with the GitHub account.

@DeltaLikeM Can you add the local email to your GitHub account email list? See the last note in this chapter: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#setting-up-your-local-environment

vsemozhetbyt reviewed Nov 6, 2017
View reviewed changes
Comment thread test/parallel/test-repl.js Outdated

vsemozhetbyt Nov 6, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

A linter nit: missing semicolon.

Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 6, 2017

Trott commented Nov 6, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/11232/

gireeshpunathil pushed a commit that referenced this pull request Nov 7, 2017
test: use fixtures module in test-repl
ac1e6bd 
PR-URL: #16809
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

gireeshpunathil commented Nov 7, 2017

Copy link
Copy Markdown
Member

Landed in ac1e6bd , thanks!

cjihrig pushed a commit to cjihrig/node that referenced this pull request Nov 7, 2017
test: use fixtures module in test-repl
6831e42 
PR-URL: nodejs#16809
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
cjihrig mentioned this pull request Nov 7, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
test: use fixtures module in test-repl
b307582 
PR-URL: #16809
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
test: use fixtures module in test-repl
4c066a4 
PR-URL: #16809
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins mentioned this pull request Nov 21, 2017
Merged
gibfahn mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
test: use fixtures module in test-repl
59bd247 
PR-URL: #16809
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
test: use fixtures module in test-repl
54d4557 
PR-URL: #16809
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes
gireeshpunathil gireeshpunathil approved these changes
+1 more reviewer
vsemozhetbyt vsemozhetbyt left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. repl Issues and PRs related to the REPL subsystem. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL