FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: used fixturesDir from fixtures modules by kkogovsek · Pull Request #16813 · nodejs/node · GitHub

/ node Public

test: used fixturesDir from fixtures modules - #16813

Closed
kkogovsek wants to merge 1 commit into
nodejs:masterfrom
kkogovsek:master
ConversationCommits (1)ChecksFiles changed
Closed

test: used fixturesDir from fixtures modules#16813
kkogovsek wants to merge 1 commit into
nodejs:masterfrom
kkogovsek:master

Conversation

kkogovsek commented Nov 6, 2017

Copy link
Copy Markdown

I required common/fixtures module and swapped the location of fixturesDir
from common to fixtures module.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 6, 2017
mscdex added the fs Issues and PRs related to the fs subsystem / file system. label Nov 6, 2017

gireeshpunathil commented Nov 6, 2017

Copy link
Copy Markdown
Member

@kkogovsek - looks like you pushed changed without:

#git config --global user.name
#git config --global user.email

on your system - implication of which is that this commit will not be associated with your profile. Can you set them up and push once again?

gireeshpunathil added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 6, 2017

vsemozhetbyt commented Nov 6, 2017

Copy link
Copy Markdown
Contributor

@kkogovsek See also the last note in this chapter: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#setting-up-your-local-environment

kkogovsek force-pushed the master branch 2 times, most recently from 774834b to a340fd4 Compare November 7, 2017 09:02

gireeshpunathil commented Nov 7, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/11261/

Trott commented Nov 7, 2017

Copy link
Copy Markdown
Member

Linter stalled in CI which was odd but undoubtedly unrelated to this change.

Re-running linter: https://ci.nodejs.org/job/node-test-linter/13348/

test: used fixturesDir from fixtures modules
1eb03a8 
In test-fs-realpath-on-substed-drive:

Require common/fixtures module and swapped the location of fixturesDir
from common to fixtures module.

Trott commented Nov 8, 2017

Copy link
Copy Markdown
Member

There was a lint error, so I fixed it up (added a semi-colon). Hope that's OK!

Need to re-run CI, but I'm having issues with CI right now....

Trott commented Nov 8, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/11298/

gireeshpunathil commented Nov 13, 2017

Copy link
Copy Markdown
Member

old CI is 404 now, new CI: https://ci.nodejs.org/job/node-test-pull-request/11388/

gireeshpunathil pushed a commit that referenced this pull request Nov 13, 2017
test: used fixturesDir from fixtures modules
1601a3c 
In test-fs-realpath-on-substed-drive, require common/fixtures
module and swapped the location of fixturesDir
from common to fixtures module.

PR-URL: #16813
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

gireeshpunathil commented Nov 13, 2017

Copy link
Copy Markdown
Member

Landed in 1601a3c , thanks for the contribution!

evanlucas pushed a commit that referenced this pull request Nov 13, 2017
test: used fixturesDir from fixtures modules
ad02676 
In test-fs-realpath-on-substed-drive, require common/fixtures
module and swapped the location of fixturesDir
from common to fixtures module.

PR-URL: #16813
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
evanlucas mentioned this pull request Nov 13, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 17, 2017
test: used fixturesDir from fixtures modules
b60ac4f 
In test-fs-realpath-on-substed-drive, require common/fixtures
module and swapped the location of fixturesDir
from common to fixtures module.

PR-URL: #16813
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins pushed a commit that referenced this pull request Nov 17, 2017
test: used fixturesDir from fixtures modules
315fba8 
In test-fs-realpath-on-substed-drive, require common/fixtures
module and swapped the location of fixturesDir
from common to fixtures module.

PR-URL: #16813
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
gibfahn mentioned this pull request Nov 21, 2017
Merged
MylesBorins mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
test: used fixturesDir from fixtures modules
02838a5 
In test-fs-realpath-on-substed-drive, require common/fixtures
module and swapped the location of fixturesDir
from common to fixtures module.

PR-URL: #16813
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
test: used fixturesDir from fixtures modules
f226ca6 
In test-fs-realpath-on-substed-drive, require common/fixtures
module and swapped the location of fixturesDir
from common to fixtures module.

PR-URL: #16813
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
Trott Trott approved these changes
gireeshpunathil gireeshpunathil approved these changes

Assignees

No one assigned

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL