test: change assert messages - #16820
Closed
PaulBlanche wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Exceptions that were thrown when they shouldn't were lost.
Copy link
Copy Markdown
Member
|
@PaulBlanche - looks like you pushed changed without: #git config --global user.name #git config --global user.email on your system - implication of which is that this commit will not be associated with your profile. Can you set them up and push once again? |
Sorry, something went wrong.
gireeshpunathil
approved these changes
Nov 6, 2017
Copy link
Copy Markdown
Contributor
|
@PaulBlanche See also the last note in this chapter: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#setting-up-your-local-environment |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Trott
approved these changes
Nov 8, 2017
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Nov 8, 2017
Include unexpected value in assertion messages. PR-URL: nodejs#16820 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Copy link
Copy Markdown
Member
|
Landed in e04d23c. Thanks for the contribution! 🎉 |
Sorry, something went wrong.
evanlucas
pushed a commit
that referenced
this pull request
Nov 13, 2017
Include unexpected value in assertion messages. PR-URL: #16820 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
gibfahn
pushed a commit
that referenced
this pull request
Dec 13, 2017
Include unexpected value in assertion messages. PR-URL: #16820 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
gabrielschulhof
pushed a commit
to gabrielschulhof/node
that referenced
this pull request
Apr 16, 2018
Include unexpected value in assertion messages. PR-URL: nodejs#16820 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exceptions that were thrown when they shouldn't were lost.
Checklist