test: remove message parameter - #16838
Closed
mbornath wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
remove the message parameter to ensure that the compared objects are printed out. add the original message as a comment above
cjihrig
approved these changes
Nov 6, 2017
maclover7
reviewed
Nov 6, 2017
Comment thread
test/parallel/test-cluster-setup-master-cumulative.js
| {}, | ||
| 'cluster.settings should not be initialized until needed' | ||
| ); | ||
| // cluster.settings should not be initialized until needed' |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
extra ' quote at the end :)
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Sorry, something went wrong.
lpinca
approved these changes
Nov 7, 2017
gireeshpunathil
approved these changes
Nov 7, 2017
Trott
approved these changes
Nov 7, 2017
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Nov 7, 2017
In test/parallel/test-cluster-setup-master-cumulative.js: Remove the message parameter to ensure that the compared objects are printed out. Add the original message as a comment above. PR-URL: nodejs#16838 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Copy link
Copy Markdown
Member
|
I removed the extra ' while landing. Landed in 6563e56. Thanks for the contribution! 🎉 |
Sorry, something went wrong.
evanlucas
pushed a commit
that referenced
this pull request
Nov 13, 2017
In test/parallel/test-cluster-setup-master-cumulative.js: Remove the message parameter to ensure that the compared objects are printed out. Add the original message as a comment above. PR-URL: #16838 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 17, 2017
In test/parallel/test-cluster-setup-master-cumulative.js: Remove the message parameter to ensure that the compared objects are printed out. Add the original message as a comment above. PR-URL: #16838 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 17, 2017
In test/parallel/test-cluster-setup-master-cumulative.js: Remove the message parameter to ensure that the compared objects are printed out. Add the original message as a comment above. PR-URL: #16838 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 21, 2017
In test/parallel/test-cluster-setup-master-cumulative.js: Remove the message parameter to ensure that the compared objects are printed out. Add the original message as a comment above. PR-URL: #16838 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 28, 2017
In test/parallel/test-cluster-setup-master-cumulative.js: Remove the message parameter to ensure that the compared objects are printed out. Add the original message as a comment above. PR-URL: #16838 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove the message parameter to ensure that the compared
objects are printed out. add the original message as a
comment above
Checklist
Affected core subsystem(s)
test, cluster