FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: change assert message arg from literal to template literal by markmcnelis · Pull Request #16843 · nodejs/node · GitHub

/ node Public

test: change assert message arg from literal to template literal - #16843

Closed
markmcnelis wants to merge 4 commits into
nodejs:masterfrom
markmcnelis:node-contribution
ConversationCommits (4)ChecksFiles changed
Closed

test: change assert message arg from literal to template literal#16843
markmcnelis wants to merge 4 commits into
nodejs:masterfrom
markmcnelis:node-contribution

Conversation

markmcnelis commented Nov 6, 2017

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 6, 2017
markmcnelis changed the title Node contribution test: change assert message arg from literal to template literal Nov 6, 2017
mscdex added v8 engine Issues and PRs related to the V8 dependency. vm Issues and PRs related to the vm subsystem. labels Nov 6, 2017
Trott previously requested changes Nov 6, 2017
View reviewed changes

Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Hi @markmcnelis! Welcome, and thanks for the PR! I have some small changes I hope you can make and then push to your branch (so it will update this PR). Thanks!

Comment thread test/parallel/test-global.js Outdated
assert.strictEqual(global.baseFoo, 'foo',
'x -> global.x in base level not working');
// eslint-disable-next-line no-undef
`${baseFoo} -> global.baseFoo in base level not

Trott Nov 6, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This would result in very confusing message, IMO. I think you might be misunderstanding the original error message text.

Try removing the eslint-disable-line comment that was added and using something like this for the message instead:

`x -> global.x failed: global.baseDir = ${global.baseDir}`

Comment thread test/parallel/test-global.js Outdated
'bar',
'global.x -> x in base level not working');
// eslint-disable-next-line no-undef
`${global.baseBar} -> baseBar in base level not

Trott Nov 6, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This too will be very confusing: "bar -> baseBar in base level not working"....huh?

Try something like this instead:

`global.x -> x failed: baseBar = ${baseBar}`

Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 6, 2017

markmcnelis commented Nov 6, 2017

Copy link
Copy Markdown
Contributor Author

Hi @Trott! Thanks for your input. I've made some changes based on your feedback. Please review if you get a chance. Thanks

gireeshpunathil commented Nov 7, 2017

Copy link
Copy Markdown
Member

@Trott - PTAL
CI: https://ci.nodejs.org/job/node-test-pull-request/11265/

Trott dismissed their stale review November 7, 2017 13:36

Looks good to me if the linter doesn't complain and CI is green. Thanks!

Trott pushed a commit to Trott/io.js that referenced this pull request Nov 7, 2017
test: improve assert messages in test-global
9468108 
PR-URL: nodejs#16843
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

Trott commented Nov 7, 2017

Copy link
Copy Markdown
Member

Landed in 9468108.
Thanks for the contribution! 🎉

Trott closed this Nov 7, 2017
evanlucas pushed a commit that referenced this pull request Nov 13, 2017
test: improve assert messages in test-global
adcaddf 
PR-URL: #16843
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
evanlucas mentioned this pull request Nov 13, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 17, 2017
test: improve assert messages in test-global
71c11d6 
PR-URL: #16843
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
gibfahn mentioned this pull request Nov 21, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes
lpinca lpinca approved these changes
gireeshpunathil gireeshpunathil approved these changes

Assignees

No one assigned

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests. v8 engine Issues and PRs related to the V8 dependency. vm Issues and PRs related to the vm subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL