tools,build: allow build without `remark-cli` by refack · Pull Request #16893 · nodejs/node · GitHub

Refs: #16635 (comment)
The lint target in the Makefile is dependant on remark-cli being installed in /tools/ or alternatively on internet access to the npm registry. The source tarball does not include remark-cli nor ESLint, so this PR uses the same conditional pattern as for lint-js:

node/Makefile

Lines 1082 to 1107 in d597317

    
           ifneq ("","$(wildcard tools/eslint/)") 
        
           lint: 
        
           	@EXIT_STATUS=0 ; \ 
        
           	$(MAKE) lint-js || EXIT_STATUS=$$? ; \ 
        
           	$(MAKE) lint-cpp || EXIT_STATUS=$$? ; \ 
        
           	$(MAKE) lint-md || EXIT_STATUS=$$? ; \ 
        
           	$(MAKE) lint-addon-docs || EXIT_STATUS=$$? ; \ 
        
           	exit $$EXIT_STATUS 
        
           CONFLICT_RE=^>>>>>>> [0-9A-Fa-f]+|^<<<<<<< [A-Za-z]+ 
        
           lint-ci: lint-js-ci lint-cpp lint-md lint-addon-docs 
        
           	@if ! ( grep -IEqrs "$(CONFLICT_RE)" benchmark deps doc lib src test tools ) \ 
        
           		&& ! ( find . -maxdepth 1 -type f | xargs grep -IEqs "$(CONFLICT_RE)" ); then \ 
        
           		exit 0 ; \ 
        
           	else \ 
        
           		echo "" >&2 ; \ 
        
           		echo "Conflict marker detected in one or more files. Please fix them first." >&2 ; \ 
        
           		exit 1 ; \ 
        
           	fi 
        
           else 
        
           lint: 
        
           	@echo "Linting is not available through the source tarball." 
        
           	@echo "Use the git repo instead:" \ 
        
           		"$ git clone https://github.com/nodejs/node.git" 
        
           lint-ci: lint 
        
           endif

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
documentation is changed or added
commit message follows commit guidelines

Affected core subsystem(s)

build,tools

CI: https://ci.nodejs.org/job/node-test-pull-request/11317/

PR-URL: nodejs#16893 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

PR-URL: #16893 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

This should be included in a general backport of remark for v6.x

refack requested review from joyeecheung and watilde November 8, 2017 23:39

nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Nov 8, 2017

refack force-pushed the mdlint-on-tarball branch from a2dc284 to 5600fb7 Compare November 8, 2017 23:46

refack added the tools Issues and PRs related to the tools directory. label Nov 8, 2017

refack mentioned this pull request Nov 8, 2017

tools: add remark dependencies #16635

Closed

2 tasks

refack force-pushed the mdlint-on-tarball branch from 5600fb7 to f889a14 Compare November 9, 2017 00:04

joyeecheung approved these changes Nov 10, 2017

View reviewed changes

tools,build: allow build without remark-cli

e624503

PR-URL: nodejs#16893 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

refack force-pushed the mdlint-on-tarball branch from f889a14 to e624503 Compare November 10, 2017 22:10

refack merged commit e624503 into nodejs:master Nov 10, 2017

refack deleted the mdlint-on-tarball branch November 10, 2017 22:13

evanlucas pushed a commit that referenced this pull request Nov 13, 2017

tools,build: allow build without remark-cli

942a9ed

PR-URL: #16893 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

evanlucas mentioned this pull request Nov 13, 2017

v9.2.0 proposal #16992

Merged

MylesBorins added the land-on-v8.x label Nov 17, 2017

MylesBorins pushed a commit that referenced this pull request Nov 17, 2017

tools,build: allow build without remark-cli

0d4f62c

PR-URL: #16893 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

MylesBorins added the lts-watch-v6.x label Nov 17, 2017

gibfahn mentioned this pull request Nov 21, 2017

v8.9.2 proposal #17204

Merged

MylesBorins added the baking-for-lts PRs that need to wait before landing in a LTS release. label Dec 20, 2017

joyeecheung mentioned this pull request Feb 1, 2018

build: added doc linting when runnning make lint #18472

Closed

1 task

MylesBorins removed the baking-for-lts PRs that need to wait before landing in a LTS release. label Aug 17, 2018

tools,build: allow build without `remark-cli` by refack · Pull Request #16893 · nodejs/node · GitHub

Uh oh!

Uh oh!

tools,build: allow build without remark-cli - #16893

tools,build: allow build without remark-cli#16893
refack merged 1 commit into
nodejs:masterfrom
refack:mdlint-on-tarball

refack commented Nov 8, 2017

Uh oh!

refack commented Nov 8, 2017 •
edited
Loading

Uh oh!

Uh oh!

MylesBorins commented Nov 17, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	ifneq ("","$(wildcard tools/eslint/)")
	lint:
	@EXIT_STATUS=0 ; \
	$(MAKE) lint-js \|\| EXIT_STATUS=$$? ; \
	$(MAKE) lint-cpp \|\| EXIT_STATUS=$$? ; \
	$(MAKE) lint-md \|\| EXIT_STATUS=$$? ; \
	$(MAKE) lint-addon-docs \|\| EXIT_STATUS=$$? ; \
	exit $$EXIT_STATUS
	CONFLICT_RE=^>>>>>>> [0-9A-Fa-f]+\|^<<<<<<< [A-Za-z]+
	lint-ci: lint-js-ci lint-cpp lint-md lint-addon-docs
	@if ! ( grep -IEqrs "$(CONFLICT_RE)" benchmark deps doc lib src test tools ) \
	&& ! ( find . -maxdepth 1 -type f \| xargs grep -IEqs "$(CONFLICT_RE)" ); then \
	exit 0 ; \
	else \
	echo "" >&2 ; \
	echo "Conflict marker detected in one or more files. Please fix them first." >&2 ; \
	exit 1 ; \
	fi
	else
	lint:
	@echo "Linting is not available through the source tarball."
	@echo "Use the git repo instead:" \
	"$ git clone https://github.com/nodejs/node.git"

	lint-ci: lint
	endif

tools,build: allow build without `remark-cli` by refack · Pull Request #16893 · nodejs/node · GitHub

Uh oh!

Uh oh!

tools,build: allow build without remark-cli - #16893

tools,build: allow build without remark-cli#16893refack merged 1 commit intonodejs:masternodejs/node:masterfrom refack:mdlint-on-tarballrefack/node:mdlint-on-tarballCopy head branch name to clipboard

Conversation

refack commented Nov 8, 2017

Checklist

Affected core subsystem(s)

Uh oh!

refack commented Nov 8, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MylesBorins commented Nov 17, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

tools,build: allow build without remark-cli#16893
refack merged 1 commit into
nodejs:masterfrom
refack:mdlint-on-tarball

refack commented Nov 8, 2017 •
edited
Loading