FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: fix a typo in the documentation by mamatha-jv · Pull Request #16909 · nodejs/node · GitHub

/ node Public

doc: fix a typo in the documentation - #16909

Closed
mamatha-jv wants to merge 1 commit into
nodejs:masterfrom
mamatha-jv:fixtypo
Closed

doc: fix a typo in the documentation#16909
mamatha-jv wants to merge 1 commit into
nodejs:masterfrom
mamatha-jv:fixtypo

Conversation

Copy link
Copy Markdown
Contributor
Checklist
  • [x ] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • [x ] documentation is changed or added
  • [ x] commit message follows commit guidelines
Affected core subsystem(s)

Trivial typo correction, this is my first PR to nodejs repo, Thanks in Advance!

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 10, 2017

apapirovski left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. Thank you!

gireeshpunathil left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

trivial change, fast-track candidate.

gireeshpunathil added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 10, 2017
gireeshpunathil pushed a commit that referenced this pull request Nov 10, 2017
PR-URL: #16909
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

Copy link
Copy Markdown
Member

Landed in 7af469a , thanks!

evanlucas pushed a commit that referenced this pull request Nov 13, 2017
PR-URL: #16909
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
evanlucas mentioned this pull request Nov 13, 2017
MylesBorins pushed a commit that referenced this pull request Nov 17, 2017
PR-URL: #16909
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
gibfahn mentioned this pull request Nov 21, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL