stream: use arrow fns for 'this' in readable - #16927
Closed
vipinmenon wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
jasnell
approved these changes
Nov 10, 2017
tniessen
approved these changes
Nov 10, 2017
apapirovski
approved these changes
Nov 10, 2017
gireeshpunathil
approved these changes
Nov 11, 2017
Comment thread
lib/_stream_readable.js
| // proxy certain important events. | ||
| for (var n = 0; n < kProxyEvents.length; n++) { | ||
| stream.on(kProxyEvents[n], self.emit.bind(self, kProxyEvents[n])); | ||
| stream.on(kProxyEvents[n], this.emit.bind(this, kProxyEvents[n])); |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
On the face of it, looks like self was not required here in the first place, the block being directly under the lexical scope of constructor function.
Sorry, something went wrong.
Comment thread
lib/_stream_readable.js
| // when we try to consume some more bytes, simply unpause the | ||
| // underlying stream. | ||
| self._read = function(n) { | ||
| this._read = (n) => { |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
same as above, self was not required here in the first place I guess.
Sorry, something went wrong.
fhinkel
approved these changes
Nov 11, 2017
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Streams is performance sensitive. Is this worth benchmarking? |
Sorry, something went wrong.
lpinca
approved these changes
Nov 11, 2017
Copy link
Copy Markdown
Member
I would say no. The changes here are extremely unlikely to yield any significant difference in the performance profile. There are other changes here that could yield improvements (such as avoiding closures) but this PR should be safe. |
Sorry, something went wrong.
addaleax
pushed a commit
that referenced
this pull request
Nov 18, 2017
PR-URL: #16927 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
PR-URL: #16927 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
gibfahn
pushed a commit
that referenced
this pull request
Dec 19, 2017
PR-URL: #16927 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Closed
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
PR-URL: #16927 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
Using arrow functions for this in readable stream.