lib: concatenated stirng to template string - #16930
Closed
pajangid wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
tniessen
approved these changes
Nov 10, 2017
jasnell
approved these changes
Nov 10, 2017
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
fhinkel
approved these changes
Nov 11, 2017
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
fhinkel
pushed a commit
that referenced
this pull request
Nov 11, 2017
PR-URL: #16930 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
Nov 13, 2017
PR-URL: #16930 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 17, 2017
PR-URL: #16930 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Copy link
Copy Markdown
Contributor
|
I've opted to not land this on v6.x as I am unsure if interpolated strings are optimized with that version of V8 |
Sorry, something went wrong.
Merged
This was referenced Mar 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
When I ran the test got the following error message, looks like unrelated to the PR
/usr/bin/python2.7 tools/test.py --mode=release -J \ async-hooks \ default \ addons addons-napi \ doctool \ known_issues === release test-async-wrap-uncaughtexception === Path: parallel/test-async-wrap-uncaughtexception Mismatched <anonymous> function calls. Expected exactly 1, actual 2. at Object.exports.mustCall (/home/k.vijayalakshmi/pawan/node/test/common/index.js:490:10) at Object.<anonymous> (/home/k.vijayalakshmi/pawan/node/test/parallel/test-async-wrap-uncaughtexception.js:14:33) at Module._compile (module.js:641:30) at Object.Module._extensions..js (module.js:652:10) at Module.load (module.js:560:32) at tryModuleLoad (module.js:503:12) at Function.Module._load (module.js:495:3) at Function.Module.runMain (module.js:682:10) at startup (bootstrap_node.js:191:16) Command: out/Release/node /home/k.vijayalakshmi/pawan/node/test/parallel/test-async-wrap-uncaughtexception.js [02:33|% 100|+ 2068|- 1]: Done Makefile:213: recipe for target 'test' failed make: *** [test] Error 1Submitting my first PR for node.js, please have a look